Skip to content

gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/_elementtree when possible - #149023

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:expat-entropy
May 10, 2026
Merged

gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/_elementtree when possible#149023
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:expat-entropy

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Apr 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Apr 26, 2026
Closed
@StanFromIreland StanFromIreland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 27, 2026
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2026
@bedevere-bot

bedevere-bot commented May 7, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit ccb8d2f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149023%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2026
@StanFromIreland StanFromIreland added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 7, 2026
@StanFromIreland

StanFromIreland commented May 8, 2026

Copy link
Copy Markdown
Member Author

@picnixz anything I should be checking specifically for, so far it's all unrelated/existing failures, but I'm also not certain as to what I should be looking for exactly?

@StanFromIreland
StanFromIreland merged commit 24b8f12 into python:main May 10, 2026
190 of 195 checks passed
@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@StanFromIreland
StanFromIreland deleted the expat-entropy branch May 10, 2026 17:36
@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24b8f12544468e4cedf5bfbe25442fcd495391e4 3.14

@bedevere-app

bedevere-app Bot commented May 10, 2026

Copy link
Copy Markdown

GH-149645 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24b8f12544468e4cedf5bfbe25442fcd495391e4 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 10, 2026
@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24b8f12544468e4cedf5bfbe25442fcd495391e4 3.12

@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24b8f12544468e4cedf5bfbe25442fcd495391e4 3.11

@miss-islington-app

miss-islington-app Bot commented May 10, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24b8f12544468e4cedf5bfbe25442fcd495391e4 3.10

@bedevere-app

bedevere-app Bot commented May 10, 2026

Copy link
Copy Markdown

GH-149646 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2026
@StanFromIreland

StanFromIreland commented May 10, 2026

Copy link
Copy Markdown
Member Author

Moving backport labels to #149646.

@StanFromIreland StanFromIreland removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 10, 2026
@hartwork

hartwork commented May 11, 2026

Copy link
Copy Markdown
Contributor

@StanFromIreland many thanks for this fix! 🙏

@david-geiger

david-geiger commented May 13, 2026

Copy link
Copy Markdown

Is there no fix/backport for python 3.13?

@StanFromIreland

StanFromIreland commented May 13, 2026

Copy link
Copy Markdown
Member Author

See #149023 (comment).

@UTsweetyfish UTsweetyfish mentioned this pull request May 14, 2026
Open
StanFromIreland added a commit that referenced this pull request Jun 9, 2026
@StanFromIreland
[3.14] gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/`_element…
eeea765 
…tree` when possible (GH-149023)

(cherry picked from commit 24b8f12)
@bedevere-app

bedevere-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

GH-151160 is a backport of this pull request to the 3.13 branch.

StanFromIreland added a commit that referenced this pull request Jun 9, 2026
@StanFromIreland
[3.13] gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/`_element…
fc9b11f 
…tree` when possible (GH-149023)

(cherry picked from commit 24b8f12)
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152188 is a backport of this pull request to the 3.10 branch.

@bedevere-app

bedevere-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

GH-155345 is a backport of this pull request to the 3.12 branch.

Yhg1s pushed a commit that referenced this pull request Aug 11, 2026
@StanFromIreland
[3.12] gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/`_element…
e37df2a 
…tree` when possible (GH-149023) (#155345)

(cherry picked from commit fc9b11f)
(cherry picked from commit 24b8f12)
@bedevere-app

bedevere-app Bot commented Aug 12, 2026

Copy link
Copy Markdown

GH-155611 is a backport of this pull request to the 3.10 branch.

pablogsal pushed a commit that referenced this pull request Aug 12, 2026
@StanFromIreland
[3.11] gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/`_element…
cbaecf9 
…tree` when possible (GH-149023) (GH-155345) (#155610)

* [3.11] gh-149018: Use `XML_SetHashSalt16Bytes` in `pyexpat`/`_elementtree` when possible (GH-149023) (GH-155345)
(cherry picked from commit e37df2a)

Co-authored-by: Stan Ulbrych <[email protected]>
(cherry picked from commit fc9b11f)
(cherry picked from commit 24b8f12)

* Apply suggestions from code review

Co-authored-by: Stan Ulbrych <[email protected]>
pablogsal pushed a commit that referenced this pull request Aug 13, 2026
@StanFromIreland
[3.10] gh-149018: Use XML_SetHashSalt16Bytes in pyexpat/`_element…
ea70712 
…tree` when possible (GH-149023) (#155611)

* [3.10] gh-149018: Use `XML_SetHashSalt16Bytes` in `pyexpat`/`_elementtree` when possible (GH-149023) (GH-155345)
(cherry picked from commit e37df2a)
(cherry picked from commit 95cf26d)

Co-authored-by: Stan Ulbrych <[email protected]>
(cherry picked from commit fc9b11f)
(cherry picked from commit 24b8f12)

* Fix SetHashSalt16Bytes assignment in pyexpat.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StanFromIreland @bedevere-bot @hartwork @david-geiger @gpshead @picnixz