gh-106246: Allow the use of unions as match patterns - #118644
Draft
randolf-scholz wants to merge 8 commits into
Draft
gh-106246: Allow the use of unions as match patterns#118644randolf-scholz wants to merge 8 commits into
randolf-scholz wants to merge 8 commits into
Conversation
randolf-scholz
requested review from
brandtbucher,
gvanrossum and
markshannon
as code owners
May 6, 2024 12:31
randolf-scholz
commented
May 6, 2024
Contributor
|
Thanks for working on this! |
sobolevn
reviewed
May 7, 2024
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
May 7, 2024 13:49
b38a4cb to
767f5dc
Compare
Member
|
Too late for 3.13 :( |
Member
|
While you have some time, I recommend adding some great docs for the new feature as well. |
Eclips4
reviewed
May 19, 2024
Contributor
|
Is the plan still to land this in 3.14? |
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
July 20, 2025 15:58
c4bff3d to
a52fd60
Compare
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
July 20, 2025 16:01
a52fd60 to
114f250
Compare
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
July 21, 2025 09:43
914fadc to
eeef8cd
Compare
randolf-scholz
marked this pull request as draft
July 21, 2025 09:44
randolf-scholz
force-pushed
the
fix-issue-118524-match-union
branch
from
July 21, 2025 09:59
eeef8cd to
4829f23
Compare
sobolevn
reviewed
Jul 21, 2025
sobolevn
left a comment
Member
There was a problem hiding this comment.
I agree, let's also add some examples to the docs 👍
Co-authored-by: sobolevn <[email protected]>
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106246
Modified version of #118525 that supports using subpatterns in unions.
added tests: