gh-61366: Read session cookies written by curl and Wget - #11792
Conversation
832444b to
8a90334
Compare
8a90334 to
b961f6b
Compare
|
Thanks for the review @ZackerySpytz, I made the requested changes. Can you review again? |
|
Could someone please review and merge this? |
|
@ZackerySpytz it looks like this PR go lost but it should be ready to go :) |
|
Bumping this since it's a long known issue and it looks like it just got forgotten. |
|
This PR is stale because it has been open for 30 days with no activity. |
test.support.TESTFN and MozillaCookieJar.header no longer exist.
…-session-cookies-in-MozillaCookieJar
Writing 0 instead of an empty field makes the file incompatible with unpatched Python, so it is left for a separate change.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Moved the writing part to separate PR. LGTM now. 👍
|
Thanks @remilapeyre for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-155603 is a backport of this pull request to the 3.15 branch. |
|
GH-155604 is a backport of this pull request to the 3.14 branch. |
|
GH-155605 is a backport of this pull request to the 3.13 branch. |
|
…GH-11792) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
…GH-11792) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
…GH-11792) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
…GH-11792) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
) (GH-155604) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
) (GH-155605) (cherry picked from commit e37cf49) Co-authored-by: Rémi Lapeyre <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
https://bugs.python.org/issue17164