gh-100335: Use correct default attrs for Dialect - #100336
Open
shoeffner wants to merge 3 commits into
Open
Conversation
sobolevn
changed the title
shoeffner
force-pushed
the
csv-dialect-defaults
branch
from
June 3, 2024 01:41
d997c4f to
830add9
Compare
shoeffner
force-pushed
the
csv-dialect-defaults
branch
from
June 3, 2024 01:59
830add9 to
be5cee2
Compare
Author
|
I rebased this and #73138 on the main branch. If I should do it again, please let me know. Now the pipelines worked, I don't know why they didn't work last year and never checked. |
|
This PR is stale because it has been open for 30 days with no activity. |
Author
It was open way longer, but I can rebase it. Just didn't want to make further rebases without some feedback. |
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the documented default attribute values for csv.Dialect as discussed in gh-100335.
The PR relies on/includes the commit of gh-100333, which should be merged first.
These changes might also resolve gh-68335 and potentially conflict with gh-96842.