Rename Ukrainian locale from 'ua' to 'uk'#986
Closed
uttam12331 wants to merge 1 commit into
Closed
Conversation
The Ukrainian locale added in python-pendulum#793 used 'ua', which is the ISO 3166 country code. The correct ISO 639-1 language code for Ukrainian is 'uk' (as used by CLDR, from which the locale data is generated). Rename the locale directory and fix its internal import accordingly. Closes python-pendulum#955
Collaborator
|
Duplicate #957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #955
The Ukrainian locale added in #793 was registered under
ua, which is the ISO 3166 country code. The correct ISO 639-1 language code for Ukrainian isuk— which is also the code CLDR uses (the source the locale data is generated from; there is noualocale in CLDR).This renames
src/pendulum/locales/ua/→src/pendulum/locales/uk/and updates the locale's internal import.Verified:
Note on backwards compatibility:
set_locale("ua")/locale="ua"will no longer resolve, sinceuawas never a valid language code. Asuawas only introduced in 3.2.0 I've done a straight rename, but if you'd prefer to keepuaas a temporary alias for one release I'm happy to add that — just say the word.Changelog updated.