Repository navigation
Remove undefined __email__ from nacl.__all__ - #974
Open
prashant1221 wants to merge 1 commit into
Open
prashant1221 wants to merge 1 commit into
prashant1221 wants to merge 1 commit into
Conversation
__email__ was removed from nacl/__init__.py but left in __all__, so 'from nacl import *' raises AttributeError: module 'nacl' has no attribute '__email__'. Drop it from __all__. Signed-off-by: Prashant S Chauhan <[email protected]>
Author
|
@reaperhulk @alex please review this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PyNaCl 1.6.0+ ,
src/nacl/__init__.pyhas:but only
__uri__and__version__are defined.__email__was removed along with__title__,__summary__,__author__,__license__and__copyright__(all defined in 1.5.0), but it was left in__all__.Reproduce:
Suggested fix: drop
"__email__"from__all__(or restore the attribute).