Repository navigation
Conversation
Readyrel
marked this pull request as ready for review
October 17, 2026 19:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Joining Solution objects with inconsistent sensitivities could cause errors or produce invalid sensitivity data.
This PR updates
Solution.__add__andSolution.from_sub_solutionsto warn and drop incompatible sensitivities while preserving the numerical solution.It also handles processed variables and time integrals, with regression tests covering mixed sensitivities, parameter mismatches, and multiple solution segments.
Fixes #5845
Type of change
Bug fix.
Added a changelog entry under
Unreleased → Bug fixesinCHANGELOG.md.Important checks:
nox -s doctests: 71 passed, 3 skipped.nox -s pre-commit: Unrelated EOF formatting issue.nox -s tests: Four Windows IDAKLU failures.Windows testing note: Similar IDAKLU native failures were reproduced on unmodified upstream main. The tests directly covering this PR passed.