fix: preserve SEA build defines on Windows - #64
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows SEA release build by switching the SEA entry bundling step from an esbuild CLI invocation (susceptible to .cmd quoting issues) to the typed Node esbuild API, ensuring crash-reporting define values are preserved correctly.
Changes:
- Replaced the
execFileSync-drivenesbuildCLI call withesbuild.buildSync(...). - Passed crash-reporting build
defines via the APIdefinemap (instead of shell-constructed--define:arguments), preserving JSON quoting on Windows. - Kept SEA bundling output/target settings consistent (
bundle,cjs,node,node24, same outfile path).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
putio-releaser Bot
added a commit
that referenced
this pull request
Aug 15, 2026
## [1.6.1](v1.6.0...v1.6.1) (2026-08-15) ### Bug Fixes * preserve SEA build defines on Windows ([#64](#64)) ([0df8cf5](0df8cf5))
Contributor
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows SEA release build after the
v1.6.0workflow exposed a shell-quoting bug in the esbuild CLI invocation.Changed
Risk
Low. This only changes how the existing SEA build options reach esbuild. It does not change crash-reporting policy, runtime telemetry behavior, or Sentry configuration.
Verification
pnpm exec vp check scripts/build-sea.mtsPUTIO_CLI_REQUIRE_SENTRY_DSN=true PUTIO_CLI_SENTRY_DSN=<public-dsn> pnpm exec vp run build:seapnpm exec vp run verify:seaenv -u PUTIO_CLI_SENTRY_DSN -u PUTIO_CLI_REQUIRE_SENTRY_DSN pnpm exec vp run verifyThe failed Windows release log for
v1.6.0reportedInvalid define valueafter the.cmdwrapper stripped JSON quoting from the CLI argument.