fix: make benchmark host builds resolve the generator correctly - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the benchmark suite so BenchmarkDotNet's autogenerated host build can compile and run.
Root cause: the host build passes \ArtifactsPath/\OutDir/\OutputPath\ and \UseSharedCompilation=false\ as global properties. Those propagated into the generator project (via its analyzer ProjectReference) and relocated its build output into stray folders relative to the project, and Roslyn's in-process analyzer loader then could not resolve the generator's \Purview.SourceGeneratorFramework\ runtime dependencies.
Changes:
Verified: filtered Release benchmark run on net10.0 executes end-to-end (32 benchmarks, no host-build failure); main + sample solutions build; csharpier lint passes.