Repository navigation
v3.30.7: isolate and quarantine empty distillation results - #100
Merged
Merged
Conversation
puretensor
force-pushed
the
audit/distill-empty-output-recovery
branch
from
September 12, 2026 10:00
45f5af7 to
9d73761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A consolidation response of
[]for captures classified as commitments preserves those captures but returns success from the chunk handler. Their retry count never increases, so an oldest-first batch can select the same captures forever and prevent newer work from being processed.Empty consolidation now enters the existing provider-failure path: bisect the batch, process healthy neighbours, charge isolated failures and quarantine after three attempts. Captures remain stored with
processed=0. The failed parent consumes nothing, preventing double-counting of noise when child batches are reclassified.Original-code evidence at
a95a43b:cargo test -p ptask-distill empty_consolidation --lockedproduced two expected failures. A healthy neighbour was not processed, and a batch-size-one empty result retained zero attempts. Both tests now pass, including mixed noise, accurate consumption counts, three-attempt quarantine, later-queue progress and retained quarantined input. Severity: medium, with high confidence from deterministic mock-provider tests; no production provider was called.Validation on Rust 1.98.1, all exit 0:
Builds used a dedicated audit target directory and CPU fence; database tests used disposable stores.
Compatibility: zero-candidate responses remain parseable, but failed conversion of kept commitments is now retried and quarantined under the existing policy. An extended provider outage can quarantine otherwise valid captures; the existing operational guide documents inspection and recovery. No capture is deleted and no schema change is needed. Workspace, internal requirements, lockfile and manpage bump together to v3.30.7; no dependency upgrade. Independent branch from
mainata95a43b, with no dependency on other audit PRs. Reconcile version stamps when landing multiple audit branches. No overlapping open work found. Remote CI runs separately; local results above were executed.Additional validation limits
Native-feature tests include existing model-dependent cases that can return early when assets are unavailable; model-loaded coverage is not claimed. Local builds were debug workspace builds, not release or cross-target builds. Dependency-policy checks passed with pre-existing yanked
chacha20 0.10.0and unusedBSD-2-Clauseallowance warnings. The upstream-backed chacha20 correction is isolated in PR #102, not folded into this defect branch.