Repository navigation
Hide unsettled GitHub traffic days from the catalog pulse - #9
Merged
Merged
Conversation
GitHub finalizes a traffic day about 36h after it closes, so the newest buckets come back empty or partial. Summing them across the catalog left two phantom zero columns at the end of the pulse chart, which read as a broken sync even though the hourly SnapshotTraffic jobs were healthy. Filter out days inside the settle window so the pulse ends on finalized data, and note the delay in the chart caption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the phantom zero columns at the end of the "Last 14 days" pulse chart.
GitHub finalizes a traffic day ~36h after it closes, so the newest buckets come back empty or partial. Summing them across the catalog left two trailing zero columns (Sep 18/19 in prod) that looked like a broken sync. Prod was in fact healthy: the worker heartbeat was fresh and SnapshotTraffic finished hourly.
Changes
cutUnsettledDays(days, now, settleHours=36)inweb/src/lib/trafficCharts.jsCatalogCharts.svelteand note the delay in the captiontrafficCharts.test.js(3 new)Verification
npm run test:fe→ 39 passedgo test ./...→ okvite build→ ok