Repository navigation
pr-review: wait out the pre-approval Sentinel verdict, and show its gates as a count - #22452
Merged
Merged
Conversation
…ates as a count act.py's post-approval wait took the newest Sentinel verdict at its word, and right after an approval that verdict is the pre-approval one, red by construction. Six merges were refused on it in one batch, every one green minutes later. The wait now ignores a red verdict older than the approval and polls up to 10 minutes for the re-evaluation. The board's checks:sentinel:failing chip said nothing a row didn't already say. collect.py now reads the gate table from the Sentinel's status comment (when it was evaluated at this head), and the row shows sentinel:P/E -- gates passing out of the ones that apply -- with each gate and the Sentinel's own words for the failing ones in the tooltip. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
github-actions
Bot
added
the
review:triaging
Contributor
Sentinel — merge gate status2 of 5 gates need attention before this can merge.
Break glass: a member of a routing team ( Evaluated at head Need help, or think a gate got it wrong? Ask in |
github-actions
Bot
added
the
domain:other
github-actions
Bot
removed
the
review:triaging
Collaborator
|
Your site preview for commit 2a150ed is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-22452-2a150ed7.s3-website.us-west-2.amazonaws.com |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
act.pySentinel wait. After approving, the wait took the newest Sentinel verdict at its word, and at that moment it's the pre-approval one, which is red by construction. Six merges in one batch were refused on it and went green minutes later. The wait now ignores a red verdict older than the approval and polls up to 10 minutes for the re-evaluation.checks:sentinel:failingis gone.collect.pyreads the gate table from the Sentinel's status comment (only when it was evaluated at the current head), and the row showssentinel P/E-- gates passing out of the ones that apply -- with each gate and the Sentinel's reason for the failing ones in the tooltip.make test-review-pipelinepasses.🤖 Generated with Claude Code