Skip to content

Fix Kubernetes YAML examples in the migration guide for yaml/v2 - #22439

Merged
nelsonfigueroa merged 2 commits into
masterfrom
fix-k8s-migration-guide-yaml-v2
Oct 22, 2026
Merged

nelsonfigueroa merged 2 commits into
masterfrom
fix-k8s-migration-guide-yaml-v2

Conversation

@nelsonfigueroa

Copy link
Copy Markdown
Member

Fixes the YAML and transforms examples in the Kubernetes migration guide. #17726 moved them to yaml/v2 but kept getResource, which v2 doesn't have:

  • The ConfigFile and ConfigGroup examples failed in every language except YAML and HCL. TypeScript, Go, and C# didn't compile, Python raised an AttributeError, and Java had no package line. They now only deploy, and the page shows kubectl get service frontend to find the cluster IP.
  • The transforms examples didn't compile in TypeScript, Go, or C#. They're now complete programs using the current transforms APIs.
  • The upstream guestbook's redis:e2e image can't be pulled on containerd 2.1 and later, so every deploy timed out. Added a sed step that switches it to redis, as the file's own comment suggests.
  • Replaced the sample outputs with real v2 output.

Page: https://www.pulumi.com/docs/iac/guides/migration/migrating-to-pulumi/from-kubernetes/

I ran every example on minikube in all six languages and checked that the transforms turn the frontend into a load balancer. I tried keeping an IP export with Service.get and dependsOn, but that only works on CLI v3.271.0 and later (pulumi/pulumi#25222), so I went with kubectl.

@github-actions github-actions Bot added the review:triaging Claude Triage is currently classifying the PR label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Sentinel — merge gate status

All gates green — nothing is blocking this merge.

Gate What it needs
✅ G1 review-ran Nothing to do: review current at a612f1fb8.
✅ G2 findings-answered Nothing to do: every finding answered.
✅ G3 right-approver Nothing to do: approved by CamSoper, who has write access.
➖ G4 infra-evidence Doesn't apply to this PR: no changed path affects the deploy.
➖ G5 oversized-ack Doesn't apply to this PR: not oversized.

Evaluated at head a612f1fb8.


Need help, or think a gate got it wrong? Ask in #docs on Slack.

@github-actions github-actions Bot added the domain:docs PR touches technical docs label Oct 22, 2026
@pulumi-bot
pulumi-bot requested a review from a team October 22, 2026 21:05
@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's guide v2 — not for the author

Tip

Check the ⚠️ items, then approve. Your approval covers only those; links, shortcodes, metadata, and verified claims were checked by machine (receipts on the evidence page). Code samples are read, not compiled.

PR author: nothing here is yours. Your to-do list is the "Author action guide" comment.

Review requested from: @pulumi/docs-guild — an approval from anyone with write access satisfies the merge gate.

Note

What this PR changes:

  • ConfigFile/ConfigGroup examples: removed getResource frontend-IP exports in every language; replaced with a kubectl get service lookup.
  • Guestbook setup: added a sed step swapping registry.k8s.io/redis:e2e for the official redis image (containerd 2.1+ can't pull schema 1 manifests).
  • pulumi up sample output: updated to kubernetes:yaml/v2 types and guestbook:default/... names, no Outputs.
  • Helm V3 Chart section: "Similar to" became "Unlike" ConfigFile/ConfigGroup for getResource.

A reader would be blocked by code samples that call APIs yaml/v2 doesn't provide, or by setup steps that fail to deploy. Fact-check (24 claims), frontmatter sweep, and a code-sample read ran.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
cross-sibling consistency MEDIUM sibling migration guides not re-read for getResource usage
code correctness MEDIUM samples read, not compiled

⚠️ Check these before approving

No findings to check — but the editorial stances below still need a human eye.

Editorial stances introduced by this PR

Superlatives and comparisons the diff adds. Framing isn't fact-checkable, so confirm each is a stance the docs should take.

  • L545 content/docs/iac/guides/migration/migrating-to-pulumi/from-kubernetes.md — "Unlike ConfigFile and ConfigGroup (v2), the Helm V3 Chart makes all provisioned resources available via the getResource function." — comparison (found by llm-atomic+llm-holistic)

✅ What you can rubber-stamp

  • Facts: 24 factual claims checked — 24 verified clean.
  • Mechanics: frontmatter sweep ran; no internal links added.

Pre-existing issues in touched files: 0 — details on the evidence page.

Full evidence: verification trail, investigation log, review history.

Review v2 · updated 2026-10-22T21:33:07Z · head commit a612f1f


For the reviewer: something look wrong? Comment /update-review <your point> and the review re-checks with your input.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Author action guide v2 — nothing blocks merge

Note

Nothing here needs an answer from you. A human reviewer still approves the merge.

This PR removes the getResource-based IP exports that yaml/v2 ConfigFile/ConfigGroup don't support, swaps the guestbook's unpullable Redis image, and refreshes the pulumi up output; the review fact-checked the changed claims and read the code samples.

Full evidence: verification trail, investigation log, review history.

Review v2 · updated 2026-10-22T21:33:07Z · head commit a612f1f


Please don't edit or delete this comment; it's the review's record.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Oct 22, 2026
@pulumi-bot

pulumi-bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added review:stale New commits since last Claude review; refresh on next ready-transition or @claude mention and removed review:no-blockers Claude review completed cleanly; outstanding is empty labels Oct 22, 2026
@nelsonfigueroa

Copy link
Copy Markdown
Member Author

/update-review

@github-actions github-actions Bot added review:in-progress Claude review is currently running review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:stale New commits since last Claude review; refresh on next ready-transition or @claude mention review:in-progress Claude review is currently running labels Oct 22, 2026
@nelsonfigueroa
nelsonfigueroa merged commit 179a534 into master Oct 22, 2026
27 checks passed
@nelsonfigueroa
nelsonfigueroa deleted the fix-k8s-migration-guide-yaml-v2 branch October 22, 2026 21:55

This branch was successfully deployed

2 active deployments
production — a612f1fb Deployed Oct 22, 2026 by nelsonfigueroa via Record review outcome #14888
testing — a612f1fb Deployed Oct 22, 2026 by nelsonfigueroa via Do cleanup #14888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:docs PR touches technical docs review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants