Repository navigation
PD trains from an explicit target signal (Buonincontri), on blochsim's bounded inverse EPG - #234
Merged
Merged
Conversation
…se EPG make_pd_target_schedule and fse3d's flip_modulation "pd_target" design a PD train by inverse EPG of an eight-parameter target signal (initial decay from the second echo, a sloped plateau, a late tail), every pulse bounded by a largest angle. The defaults PD_CENTRE and PD_PERIPHERY reproduce the trains read off Fig. 1 of Buonincontri et al. (ISMRM 2025); the fit in benchmarks/pd_buonincontri_fit.py takes its Jacobian from the exact derivatives blochsim carries through the inversion. A transition designs every shot from its own interpolated target in one batched pass. Requires blochsim 0.0.21 for maximum_flip. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01MFB6QPbxDLE71AUX5ieZ7n
Contributor
Author
|
The red test jobs are failing at install: Generated by Claude Code |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Ports the target-signal PD design of #227 onto main as an option alongside the existing
pddesign. It runs on blochsim's inverse EPG with exact derivatives and no finite differences.What it adds
make_pd_target_schedule(length, echo_spacing, ...)designs a PD train by inverse EPG of an eight-parameter target signal: an initial decay from the second echo, a sloped plateau and a late tail. Every pulse is bounded bymaximum_flip_angle. The inversion isblochsim.trains.prescribed_flips(..., maximum_flip=...)(blochsim Render Attributes sections as a field list, as Parameters are #59).PD_CENTREandPD_PERIPHERYare fitted to the trains read off Fig. 1 of Buonincontri et al. (ISMRM 2025, 566-05-007). The digitised trains are intests/fixtures/buonincontri_figure1.json.benchmarks/pd_buonincontri_fit.pyrefits them withleast_squares(jac=...), the Jacobian being the exact derivative of the angles from blochsim's forward-mode tangents. It reproduces the published parameters to the third decimal (RMS 1.0° centre, 2.4° periphery).flip_modulation="pd_target"comes withpd_target_*parameters (centre) andpd_target_*_peripheryparameters (Noneinherits the centre), pluspd_target_maximum_angle_deg(150°).pd_effective_teand the centre-echo selection work as underpd.pd_optimizeis refused, since it fits the angle-controlledpddesign.PDControlColumnsnames the target parameters.pd(first/maximum/final angles) is unchanged.Tests (
tests/test_pd_target_schedule.py)buonincontriandbuonincontri_golden;pd_optimize.Full suite locally against blochsim #59: 5445 passed, 41 skipped. CI needs blochsim 0.0.21 on PyPI (the
designextra now asks forblochsim>=0.0.21).Generated by Claude Code