Repository navigation
fse3d: golden-ratio adaptive ordering - #233
Merged
Merged
Conversation
…shot ordering "buonincontri_golden" deals each radial section of a centre/periphery transition by each shot's golden-ratio place around the turn, so a shot keeps to one angle and every arc of a ring holds the section's whole range of TRs and train lengths. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01MFB6QPbxDLE71AUX5ieZ7n
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Ports the golden-ratio ordering of #227 onto main.
ORDERINGSgains"buonincontri_golden". Like"buonincontri", it is valid only with a centre/periphery transition.deal_trains(..., golden=True)gives each shot one place around the turn: the golden-ratio fraction of its rank along the transition. Each radial section's views, sorted by angle, fill the section's slots in that order. A shot keeps to one angle, and every arc of a ring holds the section's whole range of TRs and train lengths. The default dealing (shot index sweeping with angle) is unchanged.Tests (
tests/test_fse_busse.py): the golden deal fills the same slots with the same views as the sweep; each radial section follows the shots' golden turns (and the sweep does not); the option is refused without a transition and resolves inResolvedViewOrdering.The Buonincontri target-signal PD design from #227 needs a maximum-angle bound in blochsim's inverse EPG and follows separately.
Generated by Claude Code