Repository navigation
VOP compression: grow each point to every matrix it dominates - #50
Merged
Merged
Conversation
Each point is the strongest matrix left plus the margin's share of the identity; its cluster is every matrix left that it dominates, tested by a batched Cholesky factorisation in double precision on the stack's device. The eigenvalues are taken once, on the processor. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vop.compressis the strongest matrix left plusmargin · λmax · I, and its cluster is every matrix left that the point dominates. The construction follows Eichfelder and Gebhardt.cholesky_ex(point − Q).info == 0) in complex128, on the stack's own device. The eigenvalues are taken once, on the processor: CUDA's batchedeigvalshasks for about 1 MB of workspace per 8 × 8 matrix, which is 140 GiB at 131k matrices.margin · λmax · |v|².Margin sweep (nova-coil population, A40)
"Over" is how far the points overstate the exact peak over every cube.
Tests
compVOP(skipped without cosimpy). The margin test allows a relative 1e-12, because a drive whose worst matrix leads a cluster reaches the margin exactly.bash scripts/format_and_lint.sh:92 files left unchanged/All checks passed!pytest -qon aleatico2 (A40, so the CUDA legs ran):1161 passed, 28 deselected, 20 warnings in 433.31snova-coil PR #3 uses this to write its points file.
🤖 Generated with Claude Code