Repository navigation
State each pulserver plugin's scan time in MaRGE - #23
Merged
Merged
Conversation
MaRGE asks a sequence for its scan time whenever a value is typed. The console's plugin sequences now ask pulserver to validate the values and return the scan time its reply states, in minutes; the localizer states none. Asynchronous gateways ask in the background and print the time once it arrives. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01XYJ3anWEs1W1EFN1m1fTmX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Before: editing a value of a pulserver sequence (e.g. epi2d) printed MaRGE's "sequenceTime method is empty" and a scan time of 0 minutes, because the console's plugin sequences never asked pulserver for the time. Selecting one printed "sequenceInfo method is empty".
After: each edit asks pulserver to
validatethe values and prints the scan time itsVALID <seconds>reply states, in minutes (0 where pulserver states none or the values are invalid). Through the browser's asynchronous gateway the request runs in the background and the time is printed once it arrives. The localizer states no scan time, and selecting a sequence prints its name.How:
PluginSequence.sequenceTimesends the same value block a scan sends (factored into_block) as avalidatecall and reads the status line. Pulserver's zoo evaluate already states a scan time for every shipped sequence (tests/test_zoo_evaluation.py::test_an_evaluation_states_the_values_and_the_scan_time_of_the_design).Tests:
pytest -q tests --ignore=tests/test_browser.py→ 88 passed, 1 skipped.🤖 Generated with Claude Code
https://claude.ai/code/session_01XYJ3anWEs1W1EFN1m1fTmX
Generated by Claude Code