Skip to content

Play the sound a console sends as its own message - #20

Merged
mcencini merged 1 commit into
masterfrom
console-sound-messages
Oct 8, 2026
Merged

mcencini merged 1 commit into
masterfrom
console-sound-messages

Conversation

@mcencini

@mcencini mcencini commented Oct 8, 2026

Copy link
Copy Markdown

Since pulserver/pulserver#239, the console sends each span's sound as a message of its own, {"sound", "rate", "start"}, when its clock reaches the span. The span's clock follows in a separate message. MaRGE played sound only when it came inside a clock message, so a scan now plays none. The browser suite catches this: test_a_scan_of_marges_protocol_plays_its_sound_and_returns_its_reconstruction fails with 0 s played against a 12 s clock, on #19 and on any PR built against pulserver's current main.

The scan's handler now plays any message carrying sound, and shows any message carrying clock.

Test plan

  • tests/test_pulserver_console.py: the sound test streams the console's two messages (31 passed)
  • browser suite in CI, against an image of pulserver's main

#19's browser check should pass on a re-run once this is merged.

🤖 Generated with Claude Code

The console sends each span's sound when its clock reaches the span, as a
message of its own ({"sound", "rate", "start"}), and the span's clock
after it. The scan's handler played sound only from a clock message, so
it played none.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@mcencini
mcencini merged commit c31141b into master Oct 8, 2026
3 checks passed
@mcencini
mcencini deleted the console-sound-messages branch October 8, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant