Repository navigation
Deliver each console reply to the request it answers, so overlapping scans both finish - #17
Merged
Merged
Conversation
…scans both finish Two scans requested one after the other shared the browser's WebSocket, and each request's loop discarded the replies carrying the other's id: the clock, the images and the done of both could be lost, and both waited forever. The asynchronous gateway now reads the connection one request at a time and hands every reply to the request whose id it carries. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two scans requested back to back shared the browser's WebSocket to the console. Each request's loop discarded the replies that carried the other's id, so the clock, the images and the
doneof both scans could be lost, and both waited forever. This is why a gre2D's image sometimes never appeared.AsyncGatewaynow reads the connection one request at a time and hands every reply to the request whose id it carries (_repliesqueues behind a_readinglock).Test plan
tests/test_pulserver_console.py: overlapping requests each receive their own replies🤖 Generated with Claude Code