Repository navigation
Conversation
pulserver's console now defaults to jittered voxels of eight isochromats on BrainWeb, which takes the test's gre2d scan past its 600 s timeout. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_012vtPr1RHY3npHWe7bMTGrr
Author
|
Closing: pulserver#232 removes the isochromat engines and the Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Before: on master, the Browser job's
test_a_scan_of_marges_protocol_plays_its_sound_and_returns_its_reconstructiontimed out after 600 s. Every other test passed, and the same test passed on #15's last PR run.After: the job's console runs with
--voxel point, the single isochromat per voxel that the console used before pulserver#227.Between those runs, pulserver's main branch (which the job builds its image from) gained pulserver#227. That PR makes the console default to jittered voxels of eight isochromats on BrainWeb, which multiplies the simulation the test's gre2d scan waits for. The test checks MaRGE's round trip from Acquire to a reconstruction, not the image's accuracy, so one isochromat per voxel is enough.
How: the workflow passes
--voxel pointafter the image name; the image's entry point appends options to the console's own.🤖 Generated with Claude Code
https://claude.ai/code/session_012vtPr1RHY3npHWe7bMTGrr
Generated by Claude Code