Skip to content

Scan one isochromat per voxel in the browser test's console - #16

Closed
mcencini wants to merge 1 commit into
masterfrom
claude/project-thread-97su71
Closed

mcencini wants to merge 1 commit into
masterfrom
claude/project-thread-97su71

Conversation

@mcencini

@mcencini mcencini commented Oct 6, 2026

Copy link
Copy Markdown

Requested by Matteo · project thread

Before: on master, the Browser job's test_a_scan_of_marges_protocol_plays_its_sound_and_returns_its_reconstruction timed out after 600 s. Every other test passed, and the same test passed on #15's last PR run.

After: the job's console runs with --voxel point, the single isochromat per voxel that the console used before pulserver#227.

Between those runs, pulserver's main branch (which the job builds its image from) gained pulserver#227. That PR makes the console default to jittered voxels of eight isochromats on BrainWeb, which multiplies the simulation the test's gre2d scan waits for. The test checks MaRGE's round trip from Acquire to a reconstruction, not the image's accuracy, so one isochromat per voxel is enough.

How: the workflow passes --voxel point after the image name; the image's entry point appends options to the console's own.

🤖 Generated with Claude Code

https://claude.ai/code/session_012vtPr1RHY3npHWe7bMTGrr


Generated by Claude Code

pulserver's console now defaults to jittered voxels of eight isochromats
on BrainWeb, which takes the test's gre2d scan past its 600 s timeout.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_012vtPr1RHY3npHWe7bMTGrr
@mcencini mcencini self-assigned this Oct 6, 2026

mcencini commented Oct 6, 2026

Copy link
Copy Markdown
Author

Closing: pulserver#232 removes the isochromat engines and the --voxel option along with them. The console now plays the Fourier engine only, which encodes at the trajectory's resolution and doesn't need the per-voxel isochromat count this PR lowered. Passing --voxel point would now fail as an unknown option.


Generated by Claude Code

@mcencini mcencini closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants