Repository navigation
v0.89.1 cold review: record the review and correct the statements it found - #1647
Merged
Merged
Conversation
…found Commits the one-round cold review of 69de522 unedited, with the coordinator disposition appended. Corrections, each re-derived in the disposition: - the PATCHVER record's landed field said no file under crates/ changes; the squashed PR also carries the 0.89.1 bump of 10 Cargo.toml pins - the ACTIONPIN record's landed field quoted a crates/ diff that lists 14 files on the shipped tree, not only the #1623 files; its description and verified-by now describe the per-entry group that shipped and the Dependabot check that passes at 69de522 - CHANGELOG: #1610 carries no Dependabot check, so "every commit after #1625 carried a failing check" is replaced by what the check runs show Refs #1622 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJK5LZZEkV5smCY1jKn18L
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1622
This commits the one-round cold review of the v0.89.1 candidate
69de522a(docs/reviews/v0.89.1-cold-review.md) unedited, with the coordinator disposition appended. It also corrects the false statements the review found. This PR's merge commit is the intended v0.89.1 release commit.Corrections (each re-derived in the disposition, commands and output there)
artifacts/release-v0.89.1/RQ-89-PATCHVER.yamllandedversion =pins in 10crates/*/Cargo.tomlfiles (27 pin lines, 0.89.0 to 0.89.1) and no.rsfile.artifacts/release-v0.89.1/RQ-89-ACTIONPIN.yamllandedgit diff --stat v0.89.0 origin/main -- crates/lists only the #1623 files"git diff --stat v0.89.0 69de522a -- crates/lists 14 files: the 4 of #1623 and the 10Cargo.tomlpins of the bump.CHANGELOG.md[0.89.1], CI configuration bullet.github/dependabot.ymlcheck and no grouped update applied".github/dependabot.ymlcheck failed on both commits that wrote that config (#1625 and #1627); #1610, merged between them, does not touch the file and carries no Dependabot check."RQ-89-ACTIONPINdescription,verified-by^[^@]+/scoping still did not parse, and that what ships is #1624's third commit (89f4c37, from #1628): each group under its own updates entry,github-actions-all("*") under github-actions.verified-byrecords the check runs: failure at 8002a8d and df847a1, success at 69de522. The done-when's second clause is met and its first is not (two tag refs), sostatus: proposed/disposition: partialstay.F3 re-derivation,
gh api repos/pulseengine/synth/commits/<sha>/check-runsfiltered toapp.slug == "dependabot":Gates, run on the committed head
claim_check.py claims.yaml: rc 0, 76/76 claims hold.status_evidence_check.py: rc 0. Anchorv0.89.0 — 134 delivery commits (pinned 134), 687 artifacts (pinned 687), lag 0; window5 delivery-shaped commits since v0.89.0 — 5 attributed;issue-scope: v0.89.1 over 4 artifact(s) … (authorised: #1622).verdict_prose_check.py: rc 0, 199 classified, 0 disagree.issue_closure_check.py --release v0.89.1 --since-tag v0.89.0 --allow-unclosed: rc 0,1 authorised, 0 held open, 18 closed, 0 failures. The one authorised issue is multi-memory phase 2: i64 load/store on a non-default memory under --native-pointer-abi (gale's supervisor domain has 12) #1622, still OPEN.release_file_statistics_scan.py --release v0.89.1: rc 0, 0 digit hits, 0 word-number hits./usr/bin/python3(3.9)check_py_floor.py --self-test: rc 0. Overgit ls-files '*.py': rc 0,311 file(s) under Python 3.9, 0 finding(s).loop_conformance_check.py v0.89.1: rc 1,slots=7 derived=5 attested=1 failures=1 verdict=DOES-NOT-CONFORM. The one failure is step 5's "mcdc ran on commit", which is NOT-DERIVED until CI has run on the pushed head. Every step:RQ-89-ARCHMODEL9, Recurring N/A: feature-loop steps 1-2 (spar AADL -> WIT) have been skipped every release and never filed — #912's rule applied to itself #1136, proposed).--exact-emulation-floor 394603; live run exit 0).docs/reviews/v0.89.1-cold-review.mddeclares reviewed commit69de522abbc7, which exists and is an ancestor of HEAD.git diff 89f4c37c 69de522aat 0 lines); crates and npm NA-BY-MOMENT.python3 scripts/…line in ci.yml, run underbash -o pipefailin this worktree, no synth binary built): 137 commands, 71 non-zero. All are environmental: 51oracle_evidence.pywith no evidence file; 11 oracle runs anddeterminism_checkthat need./target/debug/synth, which this worktree has not built;mcdc_gate,check_varve_shadow_pins, 3elf_static_checkandci_mutants_gatelack their build inputs;replay_control_1318; andmutation_survey.py citimed out at 300 s. None of these reads a file this PR changes. The gates this PR can move (claim, status-evidence, closure) are green above. Afterwardspgrep -fl mutation_surveywas empty,git diffwas empty (no mutant left behind), and the one untracked output (mutants-ci.txt) was removed.Squash simulation
The commit subject and this PR's title are byte-identical:
v0.89.1 cold review: record the review and correct the statements it found. It does not matchstatus_evidence_check.LANE_SUBJECT(^v\d+\.(\d+)(?:\.\d+)? ([A-Z][A-Z0-9]*)…, and "cold" is lowercase), it has no conventional-commit type, so it is not inDELIVERY_TYPES, and neither the subject nor the commit body carries anRQ-id. Thestatus_evidence_checkwindow line reads the same with this commit on top as on 69de522: "5 delivery-shaped commits since v0.89.0 — 5 attributed".Record byte facts (measured on the committed blob,
git show HEAD:docs/reviews/v0.89.1-cold-review.md)5eb44bdd105494bf959a9c58382d525a26a2f122fdf02fc3b5b57fd836842d9d, the frozen review's.Nothing is posted to any issue. Not merged by this lane.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YJK5LZZEkV5smCY1jKn18L