fix(ci): un-vacuum the mutants-core gate; dedupe the v0.33.0 changelog section - #795
Open
avrabe wants to merge 1 commit into
Open
fix(ci): un-vacuum the mutants-core gate; dedupe the v0.33.0 changelog section#795avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
…g section Two findings from the v0.33.0 pre-tag clean-room audit. Neither blocks the tag (the first is nightly + continue-on-error, the second is cosmetic), but the first is the exact defect class this release exists to remove, so it should not outlive the release that introduced it. 1. mutants-core was made UNCONDITIONALLY VACUOUS by my own REQ-288 follow-up. The empty-diff short-circuit (`if [ ! -s pr.diff ]; then exit 0`) belongs to mutants-cli, which computes pr.diff. My patch applied it to every matching check step, and mutants-core has no step that writes pr.diff — so the guard always fired and the job never evaluated outcomes.json or missed.txt for rivet-core. The in-file claim that "honest numbers surface without blocking" was false as written. Guard removed from mutants-core; mutants-cli keeps it (correct there). Root cause worth naming: a str.replace without a count. The fix for a vacuous gate introduced a vacuous gate one job over. 2. The [0.33.0] changelog section carried two `### Fixed` subheads and documented REQ-290 twice (my summary plus #776's fuller entry). Collapsed to one section, keeping the detailed entry. A duplicated section in a release about honest reporting is worth fixing before the tag, not after. yamllint clean; docs check 0 violations. Refs: REQ-288
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the v0.33.0 pre-tag clean-room audit (9/9 claims passed; these were flagged alongside). Neither blocks the tag — the first is nightly +
continue-on-error, the second cosmetic — but the first is the exact defect class this release exists to remove, so it should not outlive the release that introduced it.1.
mutants-corewas made unconditionally vacuous — by my own REQ-288 follow-upThe empty-diff short-circuit (
if [ ! -s pr.diff ]; then … exit 0) belongs tomutants-cli, which computespr.diff. My patch applied it to every matching check step, andmutants-corehas no step that writespr.diff— different job, different runner label, andactions/checkoutcleans untracked files anyway. So the guard always fired and the job never evaluatedoutcomes.jsonormissed.txtfor rivet-core. The in-file comment claiming "honest numbers surface without blocking" was false as written.Root cause worth naming plainly: a string replace without a count. The fix for a vacuous gate introduced a vacuous gate one job over — inside the release whose thesis is that a gate which cannot fail is not a gate.
Guard removed from
mutants-core;mutants-clikeeps it (correct there). Verified:mutants-corenow has 0pr.diffreferences,mutants-cliretains 5.2. Duplicated
### Fixedin the [0.33.0] changelogThe section carried two
### Fixedsubheads and documented REQ-290 twice (my summary plus #776's fuller entry). Collapsed to one, keeping the detailed entry. A duplicated section in a release about honest reporting is worth fixing before the tag rather than after.Now: one
### Fixed, REQ-290 mentioned once, all of REQ-288/289/290/291 present.yamllintclean ·docs check0 violations.Refs: REQ-288