plan(v0.34): REQ-292 — dev verification needs steps/test-name/test-location (#748) - #785
Open
avrabe wants to merge 1 commit into
Open
plan(v0.34): REQ-292 — dev verification needs steps/test-name/test-location (#748)#785avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
…cation (#748) #748 (from spar) asked for a dev-schema verification type that does not drag in ASPICE's SWE.3 chain. REQ-270 shipped that in v0.29.0 ([email protected] -> 0.3.0); the reporter was on 0.28.0/[email protected], one release short. Confirmed against the binary: `verification` exists with `verifies -> [requirement]` required and a `method` enum, so the V closes without ASPICE. The residual is field-level and is what still blocks pulseengine/spar#371: of the four fields spar's workaround uses, only `method` is declared. `steps` (142 artifacts), `test-name` (64) and `test-location` (64) are not, so migrating the 227 workaround artifacts onto `verification` would fix their V-side placement and reproduce the undeclared-field warnings. `steps` is the one that compounds: `fields.steps[].run` is the shape `rivet check verification-evidence` reads, so a dev-only project currently cannot feed that gate at all — likely why it reports 0 named-test steps here. Not closing #748; commented with the shipped-vs-remaining split instead. Trace: skip
Contributor
Automated review for PR #785pulseengine/rivet: Verdict: 💬 Comment Summary: Add fields Findings: 0 mechanical (rivet) · 1 from local AI model. Findings (1):
|
📐 Rivet artifact delta
Graphgraph LR
REQ_292["REQ-292"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files REQ-292 for v0.34 from the #748 residual.
What already shipped
#748 asked for a dev-schema verification type that doesn't drag in ASPICE's SWE.3 chain. REQ-270 delivered that in v0.29.0 (
[email protected] → 0.3.0) — the reporter was on 0.28.0/[email protected], one release short. Confirmed against the binary, not the changelog.What remains (and why spar is still blocked)
verification?methodstepstest-nametest-locationMigrating spar's 227 workaround artifacts would fix V-side placement but reproduce the undeclared-field warnings — pulseengine/spar#371 stays blocked.
stepscompounds:fields.steps[].runis exactly whatrivet check verification-evidencereads (main.rs:8205) — the gate hardened by REQ-236/REQ-280. A dev-only project can't feed it at all today, which is likely why it reports0 named-test step(s)on rivet's own repo.Also open for judgement: the issue asked for
verifies -> [any]; it shipped-> [requirement], so verifying adesign-decision/featureis inexpressible. Widening is a deliberate call, not automatic — flagged in the REQ rather than assumed.Backlog-only;
rivet validatePASS, docs check 0 violations.🤖 Generated with Claude Code