Skip to content

fix: rename CODEOWNER to CODEOWNERS so that GitHub applies it - #57

Merged
m1sk9 merged 1 commit into
mainfrom
fix/rename-codeowners
Nov 6, 2026
Merged

m1sk9 merged 1 commit into
mainfrom
fix/rename-codeowners

Conversation

@m1sk9

@m1sk9 m1sk9 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

.github/CODEOWNER を .github/CODEOWNERS に改名します.内容(* @pulsate-dev/core)は変わりません.

GitHub は CODEOWNERS という名前のファイルだけを認識します.これまでの CODEOWNER は認識されず,ルールセットの「コードオーナーのレビュー必須」は,実質的に効いていませんでした.

Impact

  • マージ後,すべての変更に,コアチーム(@pulsate-dev/core)の承認が必要になります.Renovate の自動承認(renovate-approve)だけでは,マージされなくなります.
  • 作成者本人は承認できないため,作成者以外のコア 1 人の承認が必要です.

Additional information

トラッキングの項目 AV4-6(非公開).


Generated by Claude Code

GitHub only recognizes CODEOWNERS, so the file named CODEOWNER has never
taken effect and the ruleset's code owner review requirement was
satisfied by any approval, including the auto-approval bot's.
@m1sk9
m1sk9 requested review from MikuroXina and laminne November 5, 2026 19:23
@m1sk9
m1sk9 merged commit 65033cf into main Nov 6, 2026
1 check passed
@m1sk9
m1sk9 deleted the fix/rename-codeowners branch November 6, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants