Skip to content

Bound cancellation-resistant LibGen health cleanup - #50

Merged
DeusExTaco merged 2 commits into
developfrom
feature/libgen-bounded-close-finalizer
Sep 27, 2026
Merged

DeusExTaco merged 2 commits into
developfrom
feature/libgen-bounded-close-finalizer

Conversation

@DeusExTaco

Copy link
Copy Markdown
Contributor

Summary

  • detach a health-session close task after its cleanup deadline expires
  • consume the detached task result without extending the endpoint deadline
  • add a regression transport that suppresses cancellation until explicitly released

This addresses the valid review finding on promotion PR #49.

Validation

  • focused health suite: 7 passed
  • make validate: 480 passed, 1 optional live-provider test skipped; 90.14% coverage
  • make security-check
  • make docker-source-smoke

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T16:31:20.970282Z 341aca3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 341aca3733

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread providers/libgen/src/pullbox_provider_libgen/service.py
@DeusExTaco
DeusExTaco merged commit 43e851a into develop Sep 27, 2026
30 checks passed
@DeusExTaco
DeusExTaco deleted the feature/libgen-bounded-close-finalizer branch September 27, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant