Repository navigation
Wait for long button presses - #62
Merged
Merged
Conversation
The device answers POST /vm/gpio only once the button is released, so push_button() raised TimeoutError after request_timeout (10 s by default) on longer presses, even though the device completed them. The request now waits for the press on top of request_timeout; a duration of 0 counts as the firmware default of 800 ms. Document how to force a hung target off: hold power for 6 s, wait for the power LED to go off, then press briefly to power it on again.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device answers POST /vm/gpio only once the button is released, so push_button() raised TimeoutError after request_timeout (10 s by default) on longer presses, even though the device completed them. The request now waits for the press on top of request_timeout; a duration of 0 counts as the firmware default of 800 ms.
Document how to force a hung target off: hold power for 6 s, wait for the power LED to go off, then press briefly to power it on again.