Skip to content

Improve the support for keyboard events - #58

Merged
chiconws merged 1 commit into
puddly:devfrom
antoniovazquezblanco:keyboard-events
Oct 28, 2026
Merged

chiconws merged 1 commit into
puddly:devfrom
antoniovazquezblanco:keyboard-events

Conversation

@antoniovazquezblanco

@antoniovazquezblanco antoniovazquezblanco commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Add key_down, key_up and key_tap to send USB HID keyboard reports, with
KeyCode and KeyModifier enums for the common keys and modifier bits.
key_tap releases the keys even when it is cancelled.

The keyboard and mouse now share one WebSocket and one check for which
protocol the device speaks. Firmware older than non-Pro 2.3.2 or Pro
1.2.6 only takes one key at a time, and modifiers only with a key; any
other report raises NanoKVMNotSupportedError. While the WebSocket is
open, the client sends a heartbeat every 10 seconds, as the web UI
does, so non-Pro 2.5.0 and newer don't close it when it's idle.

@chiconws

Copy link
Copy Markdown
Collaborator

Would you mind adding a short description of what this changes? It would help anyone reading the history later. Thanks!

Add key_down, key_up and key_tap to send USB HID keyboard reports, with
KeyCode and KeyModifier enums for the common keys and modifier bits.
key_tap releases the keys even when it is cancelled.

The keyboard and mouse now share one WebSocket and one check for which
protocol the device speaks. Firmware older than non-Pro 2.3.2 or Pro
1.2.6 only takes one key at a time, and modifiers only with a key; any
other report raises NanoKVMNotSupportedError. While the WebSocket is
open, the client sends a heartbeat every 10 seconds, as the web UI
does, so non-Pro 2.5.0 and newer don't close it when it's idle.
@antoniovazquezblanco

Copy link
Copy Markdown
Contributor Author

Totally right! I was being lazy hahaha Obrigado! :D

@chiconws
chiconws merged commit 3301f72 into puddly:dev Oct 28, 2026
1 check passed
@antoniovazquezblanco
antoniovazquezblanco deleted the keyboard-events branch October 28, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants