Repository navigation
Add a sync client - #57
Merged
Merged
Conversation
Contributor
Author
|
@puddly just in case you don't have notifications enabled for this repo. Sorry for the ping! Thanks! |
Owner
|
Thanks for the ping. I'll try to get to reviewing this over the weekend. |
chiconws
reviewed
Oct 25, 2026
antoniovazquezblanco
force-pushed
the
sync-client
branch
from
October 25, 2026 16:46
e970a38 to
34bd4e5
Compare
chiconws
approved these changes
Oct 25, 2026
Contributor
Author
|
Thank you very much! |
chiconws
approved these changes
Oct 25, 2026
chiconws
left a comment
chiconws
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, Antonio! Proxying through getattr means new endpoints show up in the sync client for free, and the tricky parts (Ctrl-C, closing streams early, Jupyter) are handled and tested. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for sync scripts that do not use asyncio :)