Stack/graceful deletion/03 payment drain - #19
Open
dzdidi wants to merge 2 commits into
Open
Conversation
Signed-off-by: dzdidi <[email protected]>
Signed-off-by: dzdidi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of the graceful-deletion stack. Depends on Part 2.
Adds durable payment-window tracking and claim-fenced payment draining for content locks that have entered deletion.
The change:
Rejected, canceled, proposal-expired, and accepted-expired payments are classified as
Expired, notFailed.Contract and risk impact
Migrations:
0014_paykit_invoice_windows.sql0015_content_lock_payment_drains.sqlPayment-drain mutations are fenced by the exact deletion job, worker, and claim token. Stale workers cannot persist progress after reclaim or force escalation.
Verification
The following commands were run successfully on the final combined stack:
cargo fmt --all -- --checkcargo test --workspace --all-targets --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --check codex/bitkit-local-e2e-fixes..stack/graceful-deletion/05-executionThe final run included:
locks-servicelibrary: 355 passed;This intermediate slice was not independently rerun after restacking; its isolated CI result should be recorded before merge.
Documentation
Updated:
docs/plans/2026-08-10-graceful-content-lock-deletion.mdThe plan documents authoritative payment windows, opaque drain tokens, terminal obligation handling, and crash/reclaim behavior.
Checklist