Route configure.sh's ruleset_id() Through jqr (#1253)

[ptr727]

Summary

Next in the #1123/#1234/#1246/#1247/#1253/#1254 chain. repo-config/configure.sh's ruleset_id() still read a ruleset id with a plain jq -r rather than the jqr() helper #1229 introduced, and it sits directly upstream of check_ruleset(), the function #1246/#1254 already fixed.

The defect

ids="$(jq -r --arg n "$1" '.[] | select(.name==$n) | .id' <<<"$out")"

(repo-config/configure.sh, ruleset_id(), around line 150.) On a native Windows jq, the returned id carries a trailing \r. The [ -z "$id" ] guard passes (the string is non-empty), and the CR-suffixed id is then interpolated straight into the API URL: gh api "repos/$repo/rulesets/$id". That request targets rulesets/<id>\r, which fails outright, so check_ruleset() reports "could not read live state" (or apply_ruleset() aborts) before the comparisons #1246/#1254 fixed are ever reached.

Fix

Route the extraction through the existing jqr() helper (jqr() { jq -r "$@" | sed $'s/\r$//'; }), matching every other CRLF-exposed site in this file. No behavior change on a CR-free jq (Linux/macOS).

The issue's secondary site, the bypass-list extraction in check_ruleset(), already reads through jqr() on develop (from #1254), confirmed unchanged rather than edited blind.

Verification

• shellcheck and shfmt -d both clean on repo-config/configure.sh.
• python3 scripts/prose_lint.py ., scripts/repo_gate.py, spec/validate.py, and python3 -m unittest discover -s scripts/tests (1696 tests) all pass.
• A standalone probe (bash, no network) shims jq -r to append a trailing CR (the documented native-Windows behavior), then shows the unfixed extraction yields 123\r (mismatches the expected id) while the jqr()-routed extraction yields 123 (matches), and that a real (CR-free) jq is unaffected by the fix.
• An adversarial local-review pass over this one-line diff found no defects introduced by it, and three pre-existing plain-jq CRLF-exposure sites elsewhere in the same file, filed separately as configure.sh's ruleset_id() per_page=100 Guard Reads a Plain jq, Breaking the Integer Test on Windows #1880, configure.sh's workflowModel Registry Read Is a Plain jq -r, Aborting on Windows With No Model Passed #1881, configure.sh's check_environments() Percent-Encoded Name Is a Plain jq -rn, Breaking the Branch-Policies URL on Windows #1882 rather than expanding this fix's scope.

This defect and its fix are Windows-only, and I cannot reproduce or verify the actual Windows-jq CRLF behavior on this (Linux) host. The verification above proves the CR-stripping mechanism is correct and unchanged on Linux/macOS; it does not and cannot prove the fix resolves the issue on a real Windows host. That remains unverified here, same as #1123/#1229/#1234/#1246/#1247/#1254 before it.

Closes on promotion: #1253

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d29ca5c9-00da-4e32-8927-2894953ed128

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟢 Approval recommended

The change is a minimal, consistent use of the existing jqr() normalization helper and does not alter behavior on CR-free hosts.

Review effort: Lite
Findings: None

What changed in this PR

This pull request updates repo-config/configure.sh to normalize the ruleset ID extraction in ruleset_id() by routing it through the existing jqr() helper, preventing a trailing carriage return from contaminating the ID on native Windows jq output and breaking subsequent gh api calls.

Changes:

• Switched ruleset_id()'s ruleset ID lookup from jq -r ... to jqr ... so any trailing \r is stripped before the ID is used in API paths.

File	Description
repo-config/​configure.sh	Uses jqr() for ruleset ID extraction to avoid CR-suffixed IDs breaking gh api requests on Windows.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.