Skip to content

A Copilot Review Request That Adds No Timeline Event Reads as Patience #1904

Description

@ptr727

Found driving ptr727/NxWitness#592.

What happened

After a push, pr_review.py wait auto-requested a Copilot review, waited out its full 50-minute timeout, and ended status=PENDING with requested=no. Three further requestReviews mutations returned success, the last one sent after clearing the set with botIds: [] and union: false. None of them added a review_requested event to the pull request's timeline, and reviewRequests.totalCount read 0 immediately after each one.

The maintainer then added Copilot funds, and the next identical mutation added a review_requested event at once. The review landed within minutes.

So an exhausted Copilot allowance showed up only as a request that returned success and left nothing behind. wait's quota signal did not fire, since no refusal comment was posted anywhere.

Suggested detection

After requesting, read the timeline back. Where a successful requestReviews for the Copilot bot adds no review_requested event and the pending set stays empty, report a distinct state, say request_not_recorded, naming the likely cause (the Copilot allowance or entitlement), instead of waiting out the full timeout as if the review were merely slow. The runbook's "accepted but never picked up" paragraph could name this shape too, since clearing and re-requesting does not clear it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions