Skip to content

Move the Docker Hub Owner Link to the External Group - #591

Merged
ptr727 merged 1 commit into
developfrom
feature/readme-distribution-links
Sep 26, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/readme-distribution-links

Conversation

@ptr727

@ptr727 ptr727 commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Resolves the README finding from the hub audit (run 2026-09-26T13:38:57Z | hub 45669468): "the Distribution group holds external reference(s)" per spec/readme-structure.md.

[hub-link] points at the Docker Hub owner page (hub.docker.com/u/ptr727), which is not one of this project's own repositories under hub.docker.com/r/ptr727/, so it moves from <!-- Distribution --> to <!-- External -->, sorted by reference name. Both uses of the reference are unchanged.

Local strict review: one pass, no findings.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Moved the Docker Hub organization link to the External references section. The URL remains unchanged.

The owner page is not one of this project's own Docker Hub repositories, so it belongs with the other external references rather than under Distribution.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Copilot AI lite review requested due to automatic review settings September 26, 2026 14:03
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ebe688f7-10bb-44d3-9b79-03dbb6ab3394

📥 Commits

Reviewing files that changed from the base of the PR and between 54e66f5 and 6c26283.

📒 Files selected for processing (1)
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The README moves the Docker Hub organization link definition from the Distribution references to the External references section. The URL remains unchanged.

Changes

README references

Layer / File(s) Summary
Move Docker Hub link definition
README.md
The Docker Hub organization link definition now appears under External references. Its URL is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6c262

The Docker Hub owner link is now grouped with external links, and its URL and README uses are preserved. No concrete user-facing or integration risk is evident, though the cited structure specification was unavailable for verification.

Architecture Summary

Architecture risk: 🔵 Low · up to 6c262

The change affects 1 system.

Changed systems: README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: Removed the [hub-link] reference definition from the Distribution links; its unchanged definition is now in the External links section.
  • observed — Modified behavior in README.md: Added the [hub-link] reference definition under External links, pointing to the same Docker Hub organization URL.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly describes the README change: moving the Docker Hub owner link to the External references group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is a safe documentation-only reclassification that preserves all existing link references and keeps the link-definition blocks correctly ordered.

Review effort: Lite
Findings: None

What changed in this PR

This PR updates the README’s reference-style link definitions to comply with the documented README structure rules by moving the Docker Hub owner link out of the Distribution group into the External group, without changing any in-text usage.

Changes:

  • Relocated [hub-link] (Docker Hub owner page) from <!-- Distribution --> to <!-- External -->.
  • Kept existing [hub-link] references intact and maintained alphabetical ordering within the target group.
File Description
README.md Moves the Docker Hub owner reference link definition to the correct link-definition group (External).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.01%. Comparing base (54e66f5) to head (6c26283).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #591   +/-   ##
========================================
  Coverage    57.01%   57.01%           
========================================
  Files           15       15           
  Lines         1375     1375           
  Branches       108      108           
========================================
  Hits           784      784           
  Misses         573      573           
  Partials        18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 1e3bdcf into develop Sep 26, 2026
15 checks passed
@ptr727
ptr727 deleted the feature/readme-distribution-links branch September 26, 2026 14:12
ptr727 added a commit that referenced this pull request Sep 26, 2026
Promotes `develop` at `3c0ea13` to `main`:

- #592 adopts the hub-hosted workflow tasks. It retires the six carried
tasks, pins every hub task at `2.0.685`, and adds the `docker-prepare`,
`docker-build-base`, and `codegen` hooks.
- #591 moves the Docker Hub owner link to the README's External group.

Together they close the workflow, interface, and README findings of the
hub audit run `2026-09-26T13:38:57Z | hub 45669468`, which measures
`main` and can confirm them only after this merges. The About
description was set to the README tagline separately. The Docker Hub
short description follows on the next `main` publish, since the readme
task pushes the repository description.

After this merges:

- **Codegen:** this ends the transient #592 described, a manually
dispatched `develop` codegen run whose `main` leg found no `codegen`
hook. The daily schedule on `main` then runs the hub task with the hook.
- **Publishing:** merging publishes nothing, because `Make/Matrix.json`
is unchanged. The first real run of the new publisher is the next weekly
schedule, or a `workflow_dispatch` from `main` to prove it sooner. That
run is the first to exercise the pushing `build-base` job, the
multi-arch product matrix, the GitHub release, and the Docker Hub readme
through the hub tasks, none of which a pull request smoke build reaches.

Merge with `--merge`, per the promotion convention.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants