Skip to content

Remove Version Literals From WORKFLOW.md's D1.6 Item - #390

Merged
ptr727 merged 1 commit into
developfrom
docs/no-version-literals
Sep 25, 2026
Merged

ptr727 merged 1 commit into
developfrom
docs/no-version-literals

Conversation

@ptr727

@ptr727 ptr727 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

Removes every version literal and commit SHA from AGENTS.md, GOVERNANCE.md, CODESTYLE.md, and WORKFLOW.md, per the fleet-wide rule that these four carried instruction files hold no three-part version (e.g. 1.2.3) and no commit SHA, whether a pin's value, an illustrative example, a minimum version, or a fixed constant.

A fleet scan found one hit, all in WORKFLOW.md's carried D1.6 contract item: minimum-version literals for Microsoft.Testing.Extensions.CodeCoverage (18.9.0, 18.1.0, 18.0.0) and xunit.v3 (4.0.0), stated inline as part of the MTP coverage-collector migration guidance.

Per the rule's instruction for a hub-carried D-numbered item, the D1.6 bullet is replaced wholesale with the hub's current WORKFLOW.md wording for that item (ptr727/ProjectTemplate at develop), which states the version floor by pointing at CODESTYLE.md's .NET side rather than naming the numbers inline.

AGENTS.md, GOVERNANCE.md, and CODESTYLE.md already carried no matching literals, so only WORKFLOW.md changed.

Verification

  • Re-scanned all four files with the rule's own regex after the edit: zero matches.
  • Ran the repo's Husky.Net pre-commit hook (dotnet husky run, .NET Format) on the commit: passed.
  • Confirmed the commit carries a valid SSH signature.

🤖 Generated with Claude Code

D1.6 carried the hub's coverage-reporting contract item with a stale
copy that named specific minimum versions inline (Microsoft.Testing.
Extensions.CodeCoverage 18.9.0/18.1.0/18.0.0 and xunit.v3 4.0.0), a
form the fleet rule now bans from AGENTS.md, GOVERNANCE.md,
CODESTYLE.md, and WORKFLOW.md: no three-part version and no commit
SHA, whether a pin, an example, a minimum, or a fixed constant.

Replace the D1.6 bullet with the hub's current WORKFLOW.md wording
for that item (read from ptr727/ProjectTemplate at develop), which
points the version floor at CODESTYLE.md's .NET side instead of
stating it inline. AGENTS.md, GOVERNANCE.md, and CODESTYLE.md already
carried no matching literals.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Copilot AI lite review requested due to automatic review settings September 25, 2026 15:53
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b025f489-a309-4703-b63c-2601a4063af9


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.68%. Comparing base (777d726) to head (3f28fce).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #390   +/-   ##
========================================
  Coverage    87.68%   87.68%           
========================================
  Files           11       11           
  Lines         1941     1941           
  Branches       252      252           
========================================
  Hits          1702     1702           
  Misses         166      166           
  Partials        73       73           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The updated D1.6 text now points readers to CODESTYLE.md for MTP/pytest-cov specifics that are not actually present there in this repository, making the contract misleading.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

This PR updates the carried CI/CD contract in WORKFLOW.md by replacing the D1.6 Codecov coverage guarantee text to remove inline version literals / SHAs and instead describe the same requirements without embedding pinned values.

Changes:

  • Replaced the full D1.6 “Coverage is reported to Codecov” contract bullet with wording that avoids explicit version literals/commit SHAs.
  • Reframed the coverage-collector and toolchain requirements to reference configuration locations (rather than stating numeric floors inline).
File Description
WORKFLOW.md Replaces the D1.6 Codecov coverage guarantee wording to remove version literals and align with the intended carried contract text.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread WORKFLOW.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change cleanly removes the targeted version literals by adopting the current hub contract wording without introducing new inconsistencies or verifiable defects.

Review effort: Lite
Findings: None

Resolved since last review (1)

@ptr727
ptr727 merged commit 41c6592 into develop Sep 25, 2026
14 checks passed
@ptr727
ptr727 deleted the docs/no-version-literals branch September 25, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants