Remove Version Literals From WORKFLOW.md's D1.6 Item - #390
Conversation
D1.6 carried the hub's coverage-reporting contract item with a stale copy that named specific minimum versions inline (Microsoft.Testing. Extensions.CodeCoverage 18.9.0/18.1.0/18.0.0 and xunit.v3 4.0.0), a form the fleet rule now bans from AGENTS.md, GOVERNANCE.md, CODESTYLE.md, and WORKFLOW.md: no three-part version and no commit SHA, whether a pin, an example, a minimum, or a fixed constant. Replace the D1.6 bullet with the hub's current WORKFLOW.md wording for that item (read from ptr727/ProjectTemplate at develop), which points the version floor at CODESTYLE.md's .NET side instead of stating it inline. AGENTS.md, GOVERNANCE.md, and CODESTYLE.md already carried no matching literals. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #390 +/- ##
========================================
Coverage 87.68% 87.68%
========================================
Files 11 11
Lines 1941 1941
Branches 252 252
========================================
Hits 1702 1702
Misses 166 166
Partials 73 73 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updated D1.6 text now points readers to CODESTYLE.md for MTP/pytest-cov specifics that are not actually present there in this repository, making the contract misleading.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR updates the carried CI/CD contract in WORKFLOW.md by replacing the D1.6 Codecov coverage guarantee text to remove inline version literals / SHAs and instead describe the same requirements without embedding pinned values.
Changes:
- Replaced the full D1.6 “Coverage is reported to Codecov” contract bullet with wording that avoids explicit version literals/commit SHAs.
- Reframed the coverage-collector and toolchain requirements to reference configuration locations (rather than stating numeric floors inline).
| File | Description |
|---|---|
| WORKFLOW.md | Replaces the D1.6 Codecov coverage guarantee wording to remove version literals and align with the intended carried contract text. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change cleanly removes the targeted version literals by adopting the current hub contract wording without introducing new inconsistencies or verifiable defects.
Review effort: Lite
Findings: None

Summary
Removes every version literal and commit SHA from
AGENTS.md,GOVERNANCE.md,CODESTYLE.md, andWORKFLOW.md, per the fleet-wide rule that these four carried instruction files hold no three-part version (e.g.1.2.3) and no commit SHA, whether a pin's value, an illustrative example, a minimum version, or a fixed constant.A fleet scan found one hit, all in
WORKFLOW.md's carried D1.6 contract item: minimum-version literals forMicrosoft.Testing.Extensions.CodeCoverage(18.9.0,18.1.0,18.0.0) andxunit.v3(4.0.0), stated inline as part of the MTP coverage-collector migration guidance.Per the rule's instruction for a hub-carried D-numbered item, the D1.6 bullet is replaced wholesale with the hub's current
WORKFLOW.mdwording for that item (ptr727/ProjectTemplateatdevelop), which states the version floor by pointing atCODESTYLE.md's .NET side rather than naming the numbers inline.AGENTS.md,GOVERNANCE.md, andCODESTYLE.mdalready carried no matching literals, so onlyWORKFLOW.mdchanged.Verification
dotnet husky run,.NET Format) on the commit: passed.🤖 Generated with Claude Code