Repository navigation
Build from paths containing spaces on Windows - #44
Merged
Merged
Conversation
Fixes native and Lua compiler builds on Windows/macOS/Linux when the project lives under a path containing spaces, which GNU make and the psyqo makefiles cannot resolve correctly. On Windows the build now falls back to the 8.3 short path; elsewhere (and when 8.3 names are unavailable) the build aborts with a clear error before invoking make.
CloudMracek
approved these changes
Oct 1, 2026
CloudMracek
left a comment
CloudMracek
left a comment
Contributor
There was a problem hiding this comment.
I'm so happy this got finally fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native and Lua compiler builds use GNU make, and psyqo's makefiles derive their own root via
$(abspath $(lastword $(MAKEFILE_LIST)))resolved against make's working directory, which breaks when that path contains a space. This adds a smallShortPathhelper: on Windows it resolves the native/luac working directories to their 8.3 short path viaGetShortPathNameWbefore invoking make, and on any platform (including Windows when 8.3 names are disabled) it aborts the build with a clear error before running make. The two make invocations inSplashControlPanel.cs(native build and luac_psx build) are updated to use the resolved path. Other places that shell out (git, mkpsxiso, tar, meson, toolchain installers) were audited and don't go through make, so they were left unchanged.Fixes #29.