Repository navigation
Scene view: light meshes the way the exporter does - #59
Merged
Merged
Conversation
The viewport had its own lighting (a fixed ambient, a default sun, linear falloff) that the exporter never ships, so the Scene view looked lit while the game drew everything the torch misses black. It now draws the colours the exporter bakes. Export output is unchanged. Courtyard relied on the invented light and on two empty objects: give it a Sun and a Fill light, put a Player component on Player Start, and drop the empty Main Camera.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene view meshes now use the vertex colours the exporter writes (
exportVertexColorsin splashpack.hh). The fixed ambient, default sun and linear falloff in ps1view.cpp are gone. Exports of courtyard, tests/light and tests/skin are byte-identical before and after.Courtyard: added a Sun and a Fill directional light, a Player component on Player Start, removed the empty Main Camera. Without them the game frame was black past the torch, with the camera on the floor at the origin.
Not fixed here: courtyard UVs go up to 9 on the floor and 7 on the walls. The viewport repeats them, the exporter clamps them, so in game the floor is one flat colour. Splitting tiled faces in the exporter is the next PR.