Skip to content

Drop the browser-use sentence from control-ui - #22

Merged
caelaxie merged 1 commit into
mainfrom
cursor/drop-browser-use-sentence-87ed
Oct 21, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/drop-browser-use-sentence-87ed

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

Deletes "If the browser-use tool is available, use it for the same checks." from skills/control-ui/SKILL.md. The file now matches cursor-team-kit/skills/control-ui/SKILL.md at 88d4751 byte for byte.

grok 1.0.62 does not have a browser-use tool. read_file is a real tool and prints no such warning.

$ grok --version
grok 1.0.62 (1474f9cbdd91)

$ grok -p hi --tools browser-use --max-turns 1
warning: --tools "browser-use" names no tool, so other tools stay available
Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.
Error: Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.

$ grok -p hi --tools read_file --max-turns 1
Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.
Error: Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.

The sign-in error is from the missing XAI_API_KEY. The tool warning is printed before that check. The only browser-use string in the 1.0.62 binary is an OpenCode toolset name (toolConfig browser-use), not a grok tool.

Closes #15

Open in Web Open in Cursor 

Grok 1.0.62 has no browser-use tool, so the skill matches upstream.

Co-authored-by: Kaitian Xie <[email protected]>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (proof only).

content is right. skills/control-ui/SKILL.md L8 now matches cursor-team-kit/skills/control-ui/SKILL.md @ 88d4751 byte for byte, that's exactly the #15 smallest fix, and Closes #15 is set. the --tools browser-use warning answers the issue's question.

missing: harness proof at this head. there's no ci on a2a4bf7, and the grok output above only shows the tool doesn't exist, not that the plugin still installs. post, pinned to a2a4bf7b956785d59e43d69694b82e8a94f40714:

  • grok plugin install --trust of this head + grok plugin list (and validate if available) showing pstack loaded
  • the installed copy of control-ui/SKILL.md L8 (grep or inspect) showing the sentence gone

live model turn can stay blocked on auth, same precedent as before. comment it here and i'll merge.

# Control UI

Use local browser automation to verify UI behavior with evidence. If the browser-use tool is available, use it for the same checks. First reuse the repo's own Playwright, browser, or Electron harness if it exists; otherwise assemble a temporary local harness around the app's dev server or Chromium debug port.
Use local browser automation to verify UI behavior with evidence. First reuse the repo's own Playwright, browser, or Electron harness if it exists; otherwise assemble a temporary local harness around the app's dev server or Chromium debug port.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches upstream 88d4751 L8 verbatim. good. only need install+list at this head plus the installed copy of this line.

@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Harness proof from grok 1.0.62 on head a2a4bf7b956785d59e43d69694b82e8a94f40714. No code change. Checked out that sha, fresh HOME. A live model turn is still blocked (no XAI_API_KEY); this is install, list, validate, and the installed file.

$ git rev-parse HEAD
a2a4bf7b956785d59e43d69694b82e8a94f40714

$ grok --version
grok 1.0.62 (1474f9cbdd91)

$ grok plugin validate .
Plugin manifest is valid.
  name: pstack
  version: 0.15.29
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ grok plugin install https://github.com/pstack-ports/grok-pstack@a2a4bf7b956785d59e43d69694b82e8a94f40714 --trust
Installed 1 plugin(s) from https://github.com/pstack-ports/grok-pstack@a2a4bf7b956785d59e43d69694b82e8a94f40714: pstack

$ grok plugin list --json
[
  {
    "status": "installed",
    "name": "pstack",
    "repo_key": "grok-pstack-619a4a2c",
    "version": "0.15.29",
    "path": "/tmp/grok-pr22-tsxxmihh/.grok/installed-plugins/grok-pstack-619a4a2c",
    "source": "https://github.com/pstack-ports/grok-pstack",
    "marketplace": null
  }
]

$ sed -n '8p' "$PLUGIN/skills/control-ui/SKILL.md"
Use local browser automation to verify UI behavior with evidence. First reuse the repo's own Playwright, browser, or Electron harness if it exists; otherwise assemble a temporary local harness around the app's dev server or Chromium debug port.

Line 8 does not contain "If the browser-use tool is available, use it for the same checks." CI on this sha: https://github.com/pstack-ports/grok-pstack/actions/runs/39532363960 (Validate plugin, success).

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: passes (comment review, same account). proof on head a2a4bf7: grok 1.0.62 validate + install --trust + list, installed skills/control-ui/SKILL.md L8 has no browser-use sentence and matches upstream. validate plugin ci green. squash-merging.

@caelaxie
caelaxie merged commit 67303fd into main Oct 21, 2026
1 check passed
@caelaxie
caelaxie deleted the cursor/drop-browser-use-sentence-87ed branch October 21, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: control-ui adds a browser-use tool grok does not ship

2 participants