Repository navigation
Restore typescript-best-practices paths frontmatter - #18
Conversation
Grok 1.0.62 parses a skill paths field and documents disable-model-invocation, so the upstream frontmatter and synthesizer line come back verbatim. Co-authored-by: Kaitian Xie <[email protected]>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (proof only).
content is right. both hunks are verbatim upstream 88d4751 (pstack/skills/typescript-best-practices/SKILL.md L4–5, pstack/skills/reflect/references/synthesizer.md L34), exactly #11's smallest fix. layout and parity fine, Closes #11 present, not a draft.
missing: harness proof on this plugin at this head. the inspect json in the body is a probe skill under /tmp/grok-probe-home/.grok/skills/ts-paths, not this repo. per the auth-block precedent, post as a pr comment:
grok plugin validate+grok plugin install --trustof this repo pinned to026ec1c+grok plugin listshowing itgrok inspect --json(or the installed copy) showingtypescript-best-practicesstill loads from the installed pluginhead -6of the installedskills/typescript-best-practices/SKILL.mdshowing thepaths:anddisable-model-invocation:lines, plus the installedsynthesizer.mdL34
also want ci green on this head; no checks had run when i looked. merge on proof.
| name: typescript-best-practices | ||
| description: TypeScript best practices. Use when reading or editing any .ts or .tsx file. | ||
| paths: ["**/*.ts", "**/*.tsx"] | ||
| disable-model-invocation: true |
There was a problem hiding this comment.
matches upstream L4–5. show these two lines in the installed copy after grok plugin install --trust at 026ec1c, and that the skill still appears in grok inspect --json.
|
Harness proof from grok 1.0.62 on head
{
"name": "typescript-best-practices",
"description": "TypeScript best practices. Use when reading or editing any .ts or .tsx file.",
"source": {
"type": "plugin",
"plugin_name": "pstack",
"path": "/tmp/grok-pr18-9r2cvx1h/.grok/installed-plugins/grok-pstack-619a4a2c/skills/typescript-best-practices/SKILL.md"
},
"userInvocable": true
}A session that reads a CI on this sha: https://github.com/pstack-ports/grok-pstack/actions/runs/39532384264 (Validate plugin, success). |
caelaxie
left a comment
There was a problem hiding this comment.
verdict: passes (comment review, same account). proof landed on head 026ec1c: grok 1.0.62 validate + install --trust + list, grok inspect loads typescript-best-practices from the installed plugin, installed frontmatter shows paths + disable-model-invocation, synthesizer L34 restored. live turn blocked only by cli auth, which matches the accepted precedent for text-only skill changes. validate plugin ci green. squash-merging.
Puts
paths: ["**/*.ts", "**/*.tsx"]anddisable-model-invocation: trueback inskills/typescript-best-practices/SKILL.md, and restoresskills/reflect/references/synthesizer.mdto the upstream linepath-shaped triggers belong in paths:, not description prose.disable-model-invocationis in the grok 1.0.62 user guide (~/.grok/docs/user-guide/08-skills.md) and is already set on the other skills in this port. The 1.0.62 binary's skill discovery parser accepts apathsfrontmatter key (alongsidelicense,effort,user-invocable, anddisable-model-invocation) and has a skill paths matcher (skipping invalid skill paths pattern,skill paths matcher failed to build).grok plugin validateaccepts the key.grok inspect --jsondoes not echopathsordisable-model-invocation. The guide's JSON fields arename,description,source, anduserInvocable. A skill with those keys still loads:{ "name": "ts-paths", "description": "Probe skill. Use when reading or editing any .ts or .tsx file.", "source": { "type": "user", "path": "/tmp/grok-probe-home/.grok/skills/ts-paths/SKILL.md" }, "userInvocable": true }A session that reads a
.tsfile did not start. There is noXAI_API_KEY.That turn never reached a file read, so this does not show the skill attaching. Nothing in the 1.0.62 run shows that
pathsis unread, so the upstream text is restored.Closes #11