Skip to content

Restore typescript-best-practices paths frontmatter - #18

Merged
caelaxie merged 1 commit into
mainfrom
cursor/restore-skill-paths-87ed
Oct 21, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/restore-skill-paths-87ed

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

Puts paths: ["**/*.ts", "**/*.tsx"] and disable-model-invocation: true back in skills/typescript-best-practices/SKILL.md, and restores skills/reflect/references/synthesizer.md to the upstream line path-shaped triggers belong in paths:, not description prose.

disable-model-invocation is in the grok 1.0.62 user guide (~/.grok/docs/user-guide/08-skills.md) and is already set on the other skills in this port. The 1.0.62 binary's skill discovery parser accepts a paths frontmatter key (alongside license, effort, user-invocable, and disable-model-invocation) and has a skill paths matcher (skipping invalid skill paths pattern, skill paths matcher failed to build). grok plugin validate accepts the key.

grok inspect --json does not echo paths or disable-model-invocation. The guide's JSON fields are name, description, source, and userInvocable. A skill with those keys still loads:

{
  "name": "ts-paths",
  "description": "Probe skill. Use when reading or editing any .ts or .tsx file.",
  "source": {
    "type": "user",
    "path": "/tmp/grok-probe-home/.grok/skills/ts-paths/SKILL.md"
  },
  "userInvocable": true
}

A session that reads a .ts file did not start. There is no XAI_API_KEY.

$ grok --version
grok 1.0.62 (1474f9cbdd91)

$ grok -p "Read src/hello.ts" --max-turns 1
Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.
Error: Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.

That turn never reached a file read, so this does not show the skill attaching. Nothing in the 1.0.62 run shows that paths is unread, so the upstream text is restored.

Closes #11

Open in Web Open in Cursor 

Grok 1.0.62 parses a skill paths field and documents disable-model-invocation, so the upstream frontmatter and synthesizer line come back verbatim.

Co-authored-by: Kaitian Xie <[email protected]>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (proof only).

content is right. both hunks are verbatim upstream 88d4751 (pstack/skills/typescript-best-practices/SKILL.md L4–5, pstack/skills/reflect/references/synthesizer.md L34), exactly #11's smallest fix. layout and parity fine, Closes #11 present, not a draft.

missing: harness proof on this plugin at this head. the inspect json in the body is a probe skill under /tmp/grok-probe-home/.grok/skills/ts-paths, not this repo. per the auth-block precedent, post as a pr comment:

  • grok plugin validate + grok plugin install --trust of this repo pinned to 026ec1c + grok plugin list showing it
  • grok inspect --json (or the installed copy) showing typescript-best-practices still loads from the installed plugin
  • head -6 of the installed skills/typescript-best-practices/SKILL.md showing the paths: and disable-model-invocation: lines, plus the installed synthesizer.md L34

also want ci green on this head; no checks had run when i looked. merge on proof.

name: typescript-best-practices
description: TypeScript best practices. Use when reading or editing any .ts or .tsx file.
paths: ["**/*.ts", "**/*.tsx"]
disable-model-invocation: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches upstream L4–5. show these two lines in the installed copy after grok plugin install --trust at 026ec1c, and that the skill still appears in grok inspect --json.

@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Harness proof from grok 1.0.62 on head 026ec1cdbf3490956bee9f7ade5bc4092c1074a5. No code change. Checked out that sha, fresh HOME. This install is the plugin, not the earlier /tmp probe skill.

$ git rev-parse HEAD
026ec1cdbf3490956bee9f7ade5bc4092c1074a5

$ grok --version
grok 1.0.62 (1474f9cbdd91)

$ grok plugin validate .
Plugin manifest is valid.
  name: pstack
  version: 0.15.29
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ grok plugin install https://github.com/pstack-ports/grok-pstack@026ec1cdbf3490956bee9f7ade5bc4092c1074a5 --trust
Installed 1 plugin(s) from https://github.com/pstack-ports/grok-pstack@026ec1cdbf3490956bee9f7ade5bc4092c1074a5: pstack

$ grok plugin list --json
[
  {
    "status": "installed",
    "name": "pstack",
    "repo_key": "grok-pstack-619a4a2c",
    "version": "0.15.29",
    "path": "/tmp/grok-pr18-9r2cvx1h/.grok/installed-plugins/grok-pstack-619a4a2c",
    "source": "https://github.com/pstack-ports/grok-pstack",
    "marketplace": null
  }
]

grok inspect --json wrote 35388 bytes and 59 skills. The typescript-best-practices entry loads from the installed plugin:

{
  "name": "typescript-best-practices",
  "description": "TypeScript best practices. Use when reading or editing any .ts or .tsx file.",
  "source": {
    "type": "plugin",
    "plugin_name": "pstack",
    "path": "/tmp/grok-pr18-9r2cvx1h/.grok/installed-plugins/grok-pstack-619a4a2c/skills/typescript-best-practices/SKILL.md"
  },
  "userInvocable": true
}
$ head -6 "$PLUGIN/skills/typescript-best-practices/SKILL.md"
---
name: typescript-best-practices
description: TypeScript best practices. Use when reading or editing any .ts or .tsx file.
paths: ["**/*.ts", "**/*.tsx"]
disable-model-invocation: true
---

$ sed -n '34p' "$PLUGIN/skills/reflect/references/synthesizer.md"
- "path-shaped triggers belong in `paths:`, not description prose"

A session that reads a .ts file still does not start. There is no XAI_API_KEY:

$ grok -p "Read src/hello.ts" --max-turns 1
Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.
Error: Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.

CI on this sha: https://github.com/pstack-ports/grok-pstack/actions/runs/39532384264 (Validate plugin, success).

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: passes (comment review, same account). proof landed on head 026ec1c: grok 1.0.62 validate + install --trust + list, grok inspect loads typescript-best-practices from the installed plugin, installed frontmatter shows paths + disable-model-invocation, synthesizer L34 restored. live turn blocked only by cli auth, which matches the accepted precedent for text-only skill changes. validate plugin ci green. squash-merging.

@caelaxie
caelaxie merged commit e7edfbd into main Oct 21, 2026
1 check passed
@caelaxie
caelaxie deleted the cursor/restore-skill-paths-87ed branch October 21, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: typescript-best-practices drops paths and disable-model-invocation

2 participants