Repository navigation
port pstack 0.15.36 - #45
Conversation
Ports upstream pstack/ from e73df47 (0.15.32) through c742dd6 (0.15.36): the statechart compiler, qualified action names, the SIGKILL view test, the skill updates, and the agentic Orchestrate playbook with the orch scripts removed. Co-authored-by: Kaitian Xie <[email protected]>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, since author and reviewer share an account).
checked on head 6927ae9:
- versions:
plugin.jsonand.factory-plugin/plugin.jsonboth at 0.15.36, matching upstream c742dd6. ok. - layout and target: no
.cursor/,.cursor-plugin, or Cursor paths added. ok. - embedded skills: deslop, control-cli, control-ui untouched; no cursor-team-kit mention added anywhere in the 464 files. ok.
- ci: Validate plugin green.
- linkage: no issue, none needed.
blocking:
- harness proof is missing. the body only shows
validate-plugin.mjsand the unit tests; droid itself never ran. this touches plugin content (61 skills, a new statechart compiler, deleted orch scripts), so add, on the exact head sha:droid plugin marketplace addfor this repo,droid plugin install pstack@droid-pstack, and the plugin list, plus the installed copy showingskills/statechart/present,skills/poteto-mode/scripts/orch/gone, and deslop/control-cli/control-ui loaded. if a live model turn is blocked by cli auth, install + list + the installed copy is enough for this range.
once proof lands i'll do a full verbatim pass of the ported text against upstream c742dd6, focusing on the listed droid deviations (arena/setup seat droids, interrogate seats, orchestrate state and worktrees).
|
Harness proof for head Droid 0.251.0 marketplace add worksExit 0. The Install and listInstalled commit matches this PR head. Cached Install root:
|
|
Harness proof on head Installed version Installed Installed Installed Exit 1. No Earlier 0.251.0 marketplace add, same binary, https form, also exit 0: |
caelaxie
left a comment
There was a problem hiding this comment.
pass
- verbatim pass on 6927ae9 vs upstream c742dd6: 412/464 files byte-identical, all 33 deletions (orch, old statechart, interrogate refs) mirrored, statechart scripts/tests identical bar the
@droid-skillname, deslop/control-cli/control-ui identical to the team kit, every edit a droid adaptation main already carries, no team-kit or.cursor/mention, versions 0.15.36. - harness proof #issuecomment-6458501076: droid 0.251.0 marketplace add + install + list (6927ae9) + installed copy with the new statechart and no orch; model turn blocked only by auth.
Ports upstream
pstack/frome73df47(0.15.32) throughc742dd6(0.15.36).git log e73df47..c742dd6 -- pstack/on cursor/plugins is these seven commits and nothing else.This repo does not ship
.cursor-plugin/plugin.json. Version pins land onplugin.json,.factory-plugin/plugin.json, and the README header.marketplace.jsondoes not pin a version.Upstream PRs
34b1b7cfeat(pstack): port the statechart compiler. Ported.skills/statechart/matches upstream atc742dd6, exceptscripts/package.jsonnames the package@droid-skill/statechart, the same rename this repo already uses for@droid-skill/poteto-mode-tools.7c7bde7chore(pstack): bump to 0.15.33. Ported as the version pin, then later bumps move the same fields to0.15.36.740d2c0fix(pstack): keep qualified action names in property traces. Ported inside the statechart compiler.164ced1chore(pstack): bump to 0.15.34. Ported as the version pin.519d36atest(pstack): wait for the reap in the statechart SIGKILL view test. Ported insideskills/statechart/scripts/test/cli.test.ts.ab1f702feat(pstack): port recent skill updates. Ported onto the existing Droid skills. New upstream lines are otherwise unchanged.c742dd6feat(pstack): make Orchestrate agentic and delete the orch scripts. Ported.skills/poteto-mode/scripts/orch/is deleted.skills/poteto-mode/playbooks/orchestrate.mdis the new playbook. The test script no longer runsorch.Droid deviations in this range
~/.factory/AGENTS.mdand the seat droids. Task has no per-spawn model field, so a rejectedsubagent_typedrops or moves to the next seat instead of trying another slug. Anautoorinherit-parentjudge never runs. Cross-judgeautono longer spawnsexplorer.poteto-judgment,poteto-agent, orworker), because a single generic subagent type cannot carry a model here. The deleted interrogate reference files are deleted.run_in_background: truein their own git worktree. A follow-up that needs a worker's checkout resumes that worker. A verifier uses a different seat. Control skills stay the bundledcontrol-uiandcontrol-cliskills.AskUser, session rather than VM,skills/paths, automated reviewer, and bundleddeslop.0.15.36.Checks
node scripts/validate-plugin.mjs: OK (61 skills, 5 droids).bun run typecheckandbun run testinskills/poteto-mode/scripts: 61 pass, 0 fail.npm testinskills/statechart/scriptswithTLA2TOOLSset to tla2tools.jar 1.7.4: 367 pass, 0 fail, 0 skipped. The SIGKILL view test is included.