Repository navigation
Sync pstack to upstream 0.15.26 - #5
Merged
Merged
Conversation
- add create-formal-verification-skill (upstream 4382e68, #709): verbatim body; frontmatter ported to devin conventions — disable-model-invocation becomes triggers: [user], the slash ref gains the /pstack: prefix. index it in poteto-help's routing table. - ketchup (upstream bc14437, #708): port the new rule into the rewritten reply section — never cut or shrink an action item to stay under the word count; cut story first. - bump plugin.json and .devin-plugin/plugin.json to 0.15.26 and the readme's upstream version marker. readme table and harness copies are upstream-specific surfaces this port doesn't carry; skipped. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
caelaxie
commented
Oct 18, 2026
caelaxie
left a comment
caelaxie
left a comment
Contributor
Author
There was a problem hiding this comment.
verdict: changes requested (comment review, since author and reviewer share an account).
what passes: create-formal-verification-skill matches upstream #709 byte for byte except the port's usual triggers: [user] + /pstack: translation. poteto-help row is in the right spot. versions bumped in both manifests and the readme. validate plugin is green. no issue to link.
what blocks:
- parity: upstream #692 (
16541c6) is missing. it landed between the 0.15.25 and 0.15.26 bumps, so a 0.15.26 port has to carry it. the body says "the port rewrote ketchup", but it didn't: the port's ketchup is byte-for-byte upstream's pre-#692 text (apart from the existingxychart-betaswap for/visualize). port #692 first, then #708 drops in verbatim. #692 touches:skills/ketchup/SKILL.md: description, intro, the action-item paragraph plus the new "one call can cover many items" paragraph, the whole## Write the replyrewrite, and the moved "when something is easier to grasp as a picture" paragraph under## Visuals. keep the port's/pstack:prefixes,triggers: [user], andxychart-betawording.skills/poteto-help/SKILL.md: the ketchup row becomes "Catch up on what changed in this chat since their last message, in plain words and small visuals, with every item waiting on them listed and decidable from the reply alone".
- minimum changes: ketchup L21 is a rewrite, not a port (inline comment).
- harness proof missing. the validator alone doesn't count. post real devin output:
devin plugins installon this branch, thendevin plugins listshowing pstack 0.15.26. also exercise the changed skills:/pstack:create-formal-verification-skillshows up and loads, and/pstack:ketchuploads the new text. a post-merge checkbox doesn't count as proof.
re-review on new commits or a proof comment.
| ## Write the reply | ||
|
|
||
| Keep the whole reply well under 150 words, not counting visuals. When something is easier to grasp as a picture than as sentences, draw it: how a design or system works, a PR stack or dependency chain with each PR's state, a before and after of a fix, or options side by side. Never draw a status list or boxes with nothing connecting them. Never give a fact twice, in text or across visuals. Leave out work that changed nothing for the user. When words run short, cut from what happened before you cut from the action items. | ||
| Keep the whole reply well under 150 words, not counting visuals. When something is easier to grasp as a picture than as sentences, draw it: how a design or system works, a PR stack or dependency chain with each PR's state, a before and after of a fix, or options side by side. Never draw a status list or boxes with nothing connecting them. Never give a fact twice, in text or across visuals. Leave out work that changed nothing for the user. Never cut an action item or shrink one to stay under the word count — when words run short, cut from what happened instead. |
Contributor
Author
There was a problem hiding this comment.
this is a hand-written sentence with an em dash, not upstream's. once #692 is ported, this line becomes upstream's #692 paragraph and #708 swaps in verbatim: "Never cut items or shrink them to stay under a word count: no count in place of a list, and no link in place of an item." don't keep a spirit-port here.
caelaxie
added a commit
that referenced
this pull request
Oct 18, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ports upstream #692 (16541c6) + #708 sentence verbatim that #5 missed, per portreview's review on #5 (#5 (review)). adaptations kept: triggers: [user], /pstack:, xychart-beta. harness install/list is blocked on missing devin auth. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-44778a16-2338-5d8e-a9d9-70a6a0525f7f?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-44778a16-2338-5d8e-a9d9-70a6a0525f7f&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Kaitian Xie <[email protected]>
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream
cursor/pluginspstack through0.15.26(commitsbc14437,4382e68,0b8e952).create-formal-verification-skill(#709). Body verbatim; frontmatter translated to this port's conventions —disable-model-invocation: true→triggers: [user], and the slash reference gains the/pstack:prefix. Indexed inpoteto-help's routing table at the same position as upstream.ketchupitem-protection rule (#708). Upstream's patched sentence doesn't exist verbatim here — the port rewrote ketchup — so the rule is ported in spirit onto the existing word-count line: "Never cut an action item or shrink one to stay under the word count — when words run short, cut from what happened instead." The port already covers upstream's "no link in place of an item" concern via its per-item "Link to the detail" rule.0.15.26inplugin.json,.devin-plugin/plugin.json, and the README's upstream marker.Skipped as upstream-only surfaces: the upstream
README.mdskill table (this port's README is a pointer, not a copy) and theharness/claude-code copies.Test plan
bun -escript) —Validated 55 skills, 2 agents, and 23 playbooks.devin plugins update pstacklands a new0.15.26version dir;/pstack:create-formal-verification-skillappears indevin plugins info pstackGenerated with Devin