Repository navigation
Port upstream pstack 0.15.27 - #18
Conversation
Bring in #692, #708, #709, #710, #712, #713, and #715. cursor-team-kit stays 1.2.0. Co-authored-by: Kaitian Xie <[email protected]>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same account as author).
content passes. diffed every file against upstream 019a6a205...f9be7aa00 (pstack/):
- 13 of 16 files match upstream's changed lines exactly (02, 07, 09, 10, guide readme, plugin.json, create-formal-verification-skill, ketchup, recipes, setup-pstack, sharpen).
06-verify-and-ship.mdkeeps the existing.agents/skills/path, otherwise verbatim.poteto-helpstep 2 adds upstream's offer sentence onto the existing agy tier/path line; the claude code paragraph skip is fine sincedocs/harness/claude-code.mdisn't shipped.01-setup.mdclaude code skip and README table skip are justified.- versions:
plugin.jsonand.antigravity-plugin/plugin.jsonboth0.15.27, README pin0.15.27, team-kit1.2.0. f9be7aa00 is still upstream's latest pstack commit. Validate plugin is green. no issue to link.
only blocker: harness proof. body says it follows but isn't there yet. need on 066e90c: agy plugin validate, agy plugin install + agy plugin list showing pstack 0.15.27, the script tests, and the changed skills exercised from the installed copy (at least create-formal-verification-skill present and setup-pstack showing the formal verification offer). add it to the body or a comment and i'll re-review and merge.
caelaxie
left a comment
There was a problem hiding this comment.
verdict: approved (comment review, same account as author). merging.
re-reviewed after the body edit. harness proof is now in the body for this branch (single commit 066e90c, no pushes since): agy plugin validate on the checkout and the installed copy, agy plugin install + agy plugin list showing pstack 0.15.27 (58 skills, 2 agents), installed create-formal-verification-skill, ketchup, sharpen, setup-pstack step 8 offer, and poteto-help checked from the installed copy, script tests 69/0 and typecheck clean. Validate plugin ci is green on 066e90c. content verdict from the earlier review stands.
follow-up, not blocking: upstream landed 6b78e9f4e (#721, create-formal-verification-skill TLA+ default + no-verifier fallback) after this pr opened. port it in the next sync.
summary
ports upstream cursor/plugins pstack after
019a6a205(#704) through0.15.27. cursor-team-kit stays1.2.0.git log 019a6a205..origin/main -- pstack/ cursor-team-kit/is exactly the seven commits below.ported
#69216541c6bcketchup lists every waiting item so each call is decidable#708bc1443790ketchup never cuts items to stay under a word count#7094382e687aadd/create-formal-verification-skill#7100b8e95205bump to0.15.26#71275fabace3drop the rewritten-prompt ban from sharpen#7130148b78c5bump to0.15.27#715f9be7aa00offer formal verification in setup, sync help and guideguide and skill text is copied verbatim except where this port already adapts install paths, model tiers,
invoke_subagentworkspaces, bundled/deslop, and/goalinstead of/loop. ketchup keeps thegenerative_uivisual lines. the verify-skill path stays.agents/skills/.skipped
docs/guide/01-setup.md, and the matching claude code paragraphs inskills/poteto-help/SKILL.md. they point atdocs/harness/claude-code.md, which this repo does not ship. the rest of that poteto-help paragraph is the cursor custom-modes //loopnote this port already drops.pstack/README.mdskill-table rows (ketchup wording, the new skill). this readme is the antigravity install page and does not carry that table. the version pin here is0.15.27.harness proof
agy1.4.2, installed from the antigravity cli installer. commands ran against this branch checkout with a cleanHOME.agy plugin list --jsonlistscreate-formal-verification-skill,ketchup,sharpen,setup-pstack, andpoteto-help. all 58 installed skills have frontmatternameequal to the directory. the installedcreate-formal-verification-skillskill is that folder name and contains "every case in a stated scope", "let the question choose the tool", and "prove it before you hand off". the installed ketchup skill contains "never cut items or shrink them to stay under a word count". sharpen no longer contains "don't hand back a rewritten prompt". setup-pstack has step 8, the formal verification offer. poteto-help lists the new skill, the decidable ketchup row, and the setup offer.the ci workflow on this pr passed: validate plugin, 58 skills, script typecheck, and tests.