Update to Sidekiq 8 - #13
Open
dsander wants to merge 3 commits into
Open
Conversation
This makes the tests work on ruby 3.4. No runtime gems have been updated yet. Removed usage of internal Sidekiq API in the test to hopefully make updates simpler.
`.lock` yields the lock/lock information, if it is false the lock was not acquired. Moving the mocks removes the reliance on internal API of redlock, updating it should surface breakage if they changed the API or behaviour.
Update was relatively smooth, both gems switched from `redis-rb` to `redis-client`. Apart from that a few Sidekiq APIs changed.
dsander
force-pushed
the
feature/sidekiq-8
branch
from
September 8, 2026 09:02
cd5b539 to
56b469f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.