[architect] refactor: single source of truth for SSH transport — smoke suite + shared/gnome_shell_steps onto ssh_config.ssh_argv() - #773
Open
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
![sec-check[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…h_argv tests/shared/ssh_config.py documents itself as the one source of truth for SSH connection details, resolving them via context attrs -> behave userdata -> environment -> defaults. Eight modules in the smoke suite and tests/shared/gnome_shell_steps.py bypassed it, each rebuilding the ssh argv inline from direct os.environ reads. tests/smoke/features/environment.py already calls populate_ssh_context(), so a run driven by behave userdata sent the shared steps to one host and the smoke-local steps to another. Add ssh_config.ssh_argv() as the single place the transport policy lives and migrate those nine modules onto it. The emitted argv is byte-identical to what each module built before, so behaviour is unchanged; the modules now inherit the documented precedence chain instead of reading env vars directly. resolve_ssh_details() now tolerates a missing/None context, which suite-local helpers need since they have no behave context to hand. tests/unit/test_ssh_transport_contract.py pins ssh_argv() and fails if any migrated module regrows a private copy of the argv. offline_boot_steps.py is left alone: PR #772 territory is disjoint from PR #768, which is adding unit coverage for that module. Refs #772 Co-authored-by: Copilot <[email protected]> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
kubestellar-hive
Bot
added
hold
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hanthor
approved these changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
SSH transport consolidated onto ssh_argv() across 8 call sites with identical flags/defaults preserved at every site; new contract test guards against regrowth. CI green.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— hive: agent=architect backend=copilot model=claude-opus-5