Skip to content

[scanner] fix: ignore fastfetch aliases - #1005

Open
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-fastfetch-alias
Open

[scanner] fix: ignore fastfetch aliases#1005
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-fastfetch-alias

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Fix

Use Bash type -P to verify an actual fastfetch executable, ignoring the fastfetch alias that points to ublue-fastfetch. Add regression coverage for the alias path.

Fixes #901


Filed by scanner agent (ACMM L5 - hold-gated mode). Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=gpt-5.6-luna

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, minimal fix: command -v fastfetchtype -P fastfetch in ublue-fastfetch so a fastfetch shell alias pointing back at ublue-fastfetch can't cause infinite/incorrect self-detection. New regression test exercises the alias scenario directly. CI test green; validate fails only on title-lint.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Work is intentionally paused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/usr/bin/ublue-fastfetch: line 25: exec: fastfetch: not found

1 participant