Repository navigation
fix: highlight given diagonal cell's note on the piano keyboard when clicked - #129
Merged
Merged
Conversation
…clicked handleClick short-circuited for given cells before emitting cell-click, so PlayingView never tracked them as the active cell. Even if it had, activeCellNote only read from the player-answers grid, which is always null for given cells since submitAnswer rejects writes to them. Fixes #120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MatrixGrid.vue'shandleClickshort-circuited for given cells before ever emittingcell-click, soPlayingViewnever tracked them as the active cell.PlayingView.vue'sactiveCellNotegetter only read the player-answers grid, which is permanentlynullfor given cells (submitAnswerrejects writes to them) — added the sameisGivenfallback topuzzle.cells[row][col].notethatdisplayCellsalready uses.Test plan
MatrixGrid.spec.tstest that codified the bug (does not emit cell-click when a given cell is clicked→ now asserts it does)PlayingView.spec.tstests: active-cell selection and piano keyboard highlight for a given cellnpm run lintnpm run test:unit -- --run(482 tests pass)npm run buildFixes #120