Skip to content
This repository was archived by the owner on Oct 1, 2026. It is now read-only.

Fix phantom balance status reporting - #2

Merged
privatekey7 merged 1 commit into
masterfrom
fix-phantom-balance-status-6051294480269583184
Jul 5, 2026
Merged

privatekey7 merged 1 commit into
masterfrom
fix-phantom-balance-status-6051294480269583184

Conversation

@privatekey7

Copy link
Copy Markdown
Owner

Fixes the issue where phantom balances resurfaced by ensuring uncorroborated fallback snapshots return status="ERROR" rather than "OK".


PR created automatically by Jules for task 6051294480269583184 started by @privatekey7

Currently, if the attempt budget is exhausted without reaching
CORROBORATION_MIN_AGREE, the fallback logic selects the most conservative
snapshot and returns it but leaves its status as "OK". This causes `main.py`
to accept this potentially phantom balance as a valid result.

This commit adds `chosen["status"] = "ERROR"` to the fallback logic so that
uncorroborated balances are correctly flagged as errors and excluded from the
successful totals.

Co-authored-by: privatekey7 <[email protected]>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@privatekey7
privatekey7 merged commit f1720b0 into master Jul 5, 2026
2 checks passed
@privatekey7 privatekey7 mentioned this pull request Jul 5, 2026
privatekey7 added a commit that referenced this pull request Jul 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant