Skip to content

fix: Overview scrolling and SFTP download Failure: Failure - #22

Closed
BrowLi wants to merge 0 commit into
prefnex:devfrom
BrowLi:fix/home-scroll-and-sftp-download
Closed

BrowLi wants to merge 0 commit into
prefnex:devfrom
BrowLi:fix/home-scroll-and-sftp-download

Conversation

@BrowLi

@BrowLi BrowLi commented Aug 28, 2026

Copy link
Copy Markdown

Summary

  • Restore Overview scrolling: hidden KeepAlive terminal/SFTP panes used opacity-0, so xterm still captured wheel events; the home page also lacked a bounded height under overflow-hidden.
  • Fix SFTP downloads that failed with Failure: Failure (SSH_FX_FAILURE): reads were issued against a Vec pre-sized to the whole file, so many servers rejected a single oversized SSH_FXP_READ. Downloads now stream in 32KiB chunks (directories recurse) and no longer load the entire file into memory.

Test plan

  • Open Overview after using Terminal/SFTP and confirm the page scrolls (mouse wheel and trackpad).
  • Download a file larger than ~32KB via SFTP (toolbar Download and context-menu Download).
  • Download a small file and a directory; confirm they land in the chosen local folder.
  • Cancel an in-progress download and confirm the partial dest is cleaned up.

Made with Cursor

@omarsenusi
omarsenusi changed the base branch from master to dev September 11, 2026 09:20
omarsenusi added a commit that referenced this pull request Sep 11, 2026
Fix SFTP 32KB buffer size limit by implementing chunked reads and streaming downloads to disk; fix inactive tab pointer-event wheel stealing.
@omarsenusi omarsenusi closed this Sep 11, 2026
@omarsenusi
omarsenusi force-pushed the fix/home-scroll-and-sftp-download branch from 280d831 to b1c5694 Compare September 11, 2026 09:34
@omarsenusi

Copy link
Copy Markdown
Member

Hey @BrowLi,
Thank you for this great PR! All your fixes (OpenSSH 32KiB SFTP buffer chunking, direct-to-disk streaming downloads, and fixing inactive view scroll event handling) have been fully merged into dev branch via commit b1c5694.
Appreciate the awesome contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants