feat: add the conda-script block model to pixi_manifest - #6907
Open
Hofer-Julian wants to merge 1 commit into
Open
feat: add the conda-script block model to pixi_manifest#6907Hofer-Julian wants to merge 1 commit into
pixi_manifest#6907Hofer-Julian wants to merge 1 commit into
Conversation
Hofer-Julian
changed the title
pixi_conda_script crate with the block parser and TOML model
Hofer-Julian
force-pushed
the
conda-script-parser
branch
2 times, most recently
from
August 27, 2026 15:30
fe4a43d to
9d4a9b3
Compare
Hofer-Julian
changed the title
pixi_conda_script crate with the block parser and TOML modelpixi_manifest
Hofer-Julian
force-pushed
the
conda-script-parser
branch
2 times, most recently
from
August 31, 2026 11:49
057ca70 to
aa105fe
Compare
Hofer-Julian
marked this pull request as ready for review
August 31, 2026 12:43
Hofer-Julian
force-pushed
the
conda-script-parser
branch
2 times, most recently
from
September 3, 2026 12:35
965e65f to
412b5aa
Compare
hunger
approved these changes
Sep 4, 2026
hunger
left a comment
hunger
left a comment
Contributor
There was a problem hiding this comment.
My feeling is that how files with several blocks are not going to get handled too well, but that is a corner-case you probably won't run into often, so I did not want to spend too much time on that.
I did not look into that too deeply, maybe you can ask your agent to validate that bit a bit deeper.
| Err(_) => { | ||
| errors.errors.push(custom_error( | ||
| format!( | ||
| "'{name}' is neither a platform family (`unix`, `linux`, `osx`, `win`) nor a conda platform" |
Contributor
There was a problem hiding this comment.
What is a conda platform? A subdir?
You are passing the name to the output without any sanitization, ESC codes and all.
| } | ||
|
|
||
| let path = std::path::absolute(path)?; | ||
| let source: Arc<str> = Arc::from(std::str::from_utf8(contents)?); |
Contributor
There was a problem hiding this comment.
You require the entire file to be utf8 encoded here if I read that correctly. Not all languages require their source code to be utf-8, so that might cause problems.
| let mut name_spans: IndexMap<Name, toml_span::Span> = IndexMap::new(); | ||
| for (key, mut value) in table.into_iter().sorted_by_key(|(key, _)| key.span.start) { | ||
| let name = match Name::from_str(&key.name) { | ||
| Ok(name) => name, |
Contributor
There was a problem hiding this comment.
IIRC empty Names are Ok, you probably do not want those though.
| let mut errors = DeserError { errors: Vec::new() }; | ||
|
|
||
| let channels = th | ||
| .required_s::<Vec<TomlFromStr<NamedChannelOrUrl>>>("channels") |
Contributor
There was a problem hiding this comment.
I think you can end up with empty channels in the list here...
Hofer-Julian
force-pushed
the
conda-script-parser
branch
from
September 4, 2026 13:48
412b5aa to
d06f01b
Compare
The first piece of the `conda-script` proposal (#3751): the `/// conda-script` comment block parsed as a script manifest next to the PEP 723 one. `script::block` holds the machinery both kinds share: comment-prefix stripping, source maps for diagnostics and serializing edits back into the block. The model covers `channels`, `entrypoint` (string or platform table), `[dependencies]` restricted to the keys the spec defines, and `[tool.pixi]` with `dependencies` and `pypi-dependencies`. Edits round-trip: `metadata_document` exposes the block as TOML and `write_metadata` writes it back through the comment prefix.
Hofer-Julian
force-pushed
the
conda-script-parser
branch
from
September 4, 2026 14:04
d06f01b to
433950f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/// conda-scriptcomment block (#3751) parsed as a script manifest next to the PEP 723 one.pixi_manifest::scriptsplits into machinery both block kinds share (comment-prefix stripping, source maps for diagnostics, serializing edits back into the block) and one submodule per kindchannels,entrypoint(string or platform table),[dependencies],[tool.pixi]withdependenciesandpypi-dependencies[dependencies]rejects pixi-build specs (git,path, aurlthat is not a conda archive)