Skip to content

RFC 3986 enabled by default - #4581

Merged
CTMBNara merged 2 commits into
masterfrom
RFC-3986-enabled-by-default
Jul 30, 2026
Merged

RFC 3986 enabled by default#4581
CTMBNara merged 2 commits into
masterfrom
RFC-3986-enabled-by-default

Conversation

@osulzhenko

@osulzhenko osulzhenko commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Net-burst
Net-burst previously approved these changes Jul 30, 2026

@Net-burst Net-burst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lightwood13
Lightwood13 previously approved these changes Jul 30, 2026
@osulzhenko
osulzhenko dismissed stale reviews from Lightwood13 and Net-burst via 681fd7b July 30, 2026 14:36
@CTMBNara
CTMBNara merged commit af2f528 into master Jul 30, 2026
7 of 8 checks passed
@CTMBNara
CTMBNara deleted the RFC-3986-enabled-by-default branch July 30, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants