Skip to content

pppd: Keep EAP-TLS engines local to SSL initialization - #667

Open
grey3228 wants to merge 1 commit into
ppp-project:masterfrom
grey3228:fix/eaptls-engine-state
Open

grey3228 wants to merge 1 commit into
ppp-project:masterfrom
grey3228:fix/eaptls-engine-state

Conversation

@grey3228

Copy link
Copy Markdown
Contributor

The engine pointers survive between calls to eaptls_init_ssl(), but their names do not. Switching from an engine certificate to a file certificate while keeping an engine key can therefore pass a NULL certificate engine name to strcmp(). File credentials can also be passed to an engine retained from an earlier connection.

Keep the pointers local to each call and release the engine references on both success and failure, taking care to release a shared reference only once. Only the OpenSSL configuration needs to remain cached.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

The engine pointers survive between calls to eaptls_init_ssl(), but
their names do not. Switching from an engine certificate to a file
certificate while keeping an engine key can therefore pass a NULL
certificate engine name to strcmp(). File credentials can also be
passed to an engine retained from an earlier connection.

Keep the pointers local to each call and release the engine references
on both success and failure, taking care to release a shared reference
only once. Only the OpenSSL configuration needs to remain cached.

Found by Linux Verification Center (linuxtesting.org) with SVACE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant