Repository navigation
Conversation
The engine pointers survive between calls to eaptls_init_ssl(), but their names do not. Switching from an engine certificate to a file certificate while keeping an engine key can therefore pass a NULL certificate engine name to strcmp(). File credentials can also be passed to an engine retained from an earlier connection. Keep the pointers local to each call and release the engine references on both success and failure, taking care to release a shared reference only once. Only the OpenSSL configuration needs to remain cached. Found by Linux Verification Center (linuxtesting.org) with SVACE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine pointers survive between calls to eaptls_init_ssl(), but their names do not. Switching from an engine certificate to a file certificate while keeping an engine key can therefore pass a NULL certificate engine name to strcmp(). File credentials can also be passed to an engine retained from an earlier connection.
Keep the pointers local to each call and release the engine references on both success and failure, taking care to release a shared reference only once. Only the OpenSSL configuration needs to remain cached.
Found by Linux Verification Center (linuxtesting.org) with SVACE.