Cares==1_19_1 ubi10.2 - #8725
Conversation
|
Check the build failure https://github.com/ppc64le/build-scripts/actions/runs/33722632017/job/100546784493?pr=8725 |
| test -f ${SITE_PACKAGE_PATH}/cares/include/ares.h || { echo "ERROR: ares.h not exists." ; exit 1; } | ||
| test -f ${SITE_PACKAGE_PATH}/cares/lib/libcares.so || { echo "ERROR: libcares.so not exists." ; exit 1; } | ||
| test ! -f ${SITE_PACKAGE_PATH}/cares/lib/libcares.a || { echo "ERROR: libcares.a exists." ; exit 1; } | ||
| test ! -f ${SITE_PACKAGE_PATH}/cares/lib/libcares_static.a || { echo "ERROR: libcares_static.a exists." ; exit 1; } No newline at end of file |
There was a problem hiding this comment.
Can you also execute the test command instead of just validating whether the file exists?
Check https://github.com/ppc64le/build-scripts/blob/master/c/c-ares/cares_ubi_9.3.sh#L99C1-L112C3
| fi | ||
| SITE_PACKAGE_PATH=$(python3.14 -m pip show c-ares | awk -F': ' '/^Location:/ {print $2}') | ||
|
|
||
| test -f ${SITE_PACKAGE_PATH}/cares/include/ares.h || { echo "ERROR: ares.h not exists." ; exit 1; } |
There was a problem hiding this comment.
I don't think we explicitly need to check if these files exists, any specific reason for checking these?
Running the ninja test should be sufficient.
There was a problem hiding this comment.
These validations were present in the script that Nayana shared.
|
@tejasBadjateIBM , can you squash all your commits into a single commit. After that we are good to merge this pr. |
636d100 to
42d94c4
Compare
|
LGTM |
4 participants
Checklist
set -eoption enabled and observe success ?